Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-33283: Adjust NAD name to "network-xxx-xxx" when creating #13820

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-33283: Adjust NAD name to "network-xxx-xxx" when creating #13820

wants to merge 1 commit into from
+39 −18

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #13568

/assign gouyang

@hstastna
OCPBUGS-22749: Adjust NAD name to "network-xxx-xxx" when creating
731658a 
Adjust new NetworkAttachmentDefinition name to be generated
automatically and displayed in the Name input when creating a new NAD,
to prevent creating a shared NAD between isolated namespaces.
Add the popover to inform the user that "Networks are not project-bound.
Using the same name creates a shared NAD."

Fixes https://issues.redhat.com/browse/OCPBUGS-22749
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 6, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-22749 has been cloned as Jira Issue OCPBUGS-33283. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-33283: Adjust NAD name to "network-xxx-xxx" when creating

In response to this:

This is an automated cherry-pick of #13568

/assign gouyang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-22749: Adjust NAD name to "network-xxx-xxx" when creating [release-4.15] OCPBUGS-33283: Adjust NAD name to "network-xxx-xxx" when creating May 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33283, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-22749 to target a version in 4.16.0, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #13568

/assign gouyang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 6, 2024
@openshift-ci openshift-ci bot requested review from pcbailey and rawagner May 6, 2024 02:45
@openshift-ci openshift-ci bot added component/network-attachment-definition Related to network-attachment-definition kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 6, 2024
@jhadvig
Copy link
Member

jhadvig commented May 6, 2024

/label backport-risk-assessed
/approve
jira refresh

@jhadvig
Copy link
Member

jhadvig commented May 6, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-33283, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-22749 to target a version in 4.16.0, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 6, 2024
@gouyang
Copy link
Contributor

gouyang commented May 6, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 6, 2024
@gouyang
Copy link
Contributor

gouyang commented May 6, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Jira Issue OCPBUGS-33283, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gouyang
Copy link
Contributor

gouyang commented May 6, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Jira Issue OCPBUGS-33283, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gouyang
Copy link
Contributor

gouyang commented May 6, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 6, 2024
@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Jira Issue OCPBUGS-33283, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-22749 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22749 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei May 6, 2024 22:33
@pcbailey
Copy link
Contributor

pcbailey commented May 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, openshift-cherrypick-robot, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 157ae85 and 2 for PR HEAD 731658a in total

@metalice
Copy link
Contributor

metalice commented May 7, 2024

/retest

@gouyang
Copy link
Contributor

gouyang commented May 7, 2024

/test e2e-gcp-console

1 similar comment
@gouyang
Copy link
Contributor

gouyang commented May 8, 2024

/test e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 789c888 and 1 for PR HEAD 731658a in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9ba2632 and 0 for PR HEAD 731658a in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 731658a was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@gouyang
Copy link
Contributor

gouyang commented May 11, 2024

/test e2e-gcp-console

2 similar comments
@gouyang
Copy link
Contributor

gouyang commented May 13, 2024

/test e2e-gcp-console

@gouyang
Copy link
Contributor

gouyang commented May 20, 2024

/test e2e-gcp-console

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 731658a link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gouyang
Copy link
Contributor

gouyang commented May 23, 2024

@metalice could you take a look at this again?

@gouyang
Copy link
Contributor

gouyang commented May 27, 2024

@metalice it seems the PR cannot pass the e2e-gcp-console test before the conflict was found, could you take a look at this again because there is a request to backport this to 4.15.

@gouyang
Copy link
Contributor

gouyang commented May 27, 2024

/test e2e-gcp-console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey Awaiting requested review from pcbailey

@rawagner rawagner Awaiting requested review from rawagner

@yapei yapei Awaiting requested review from yapei

Assignees

@gouyang gouyang

@jrichter1 jrichter1

@ebenahar ebenahar

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@juzhao juzhao

@The-Anton The-Anton

@lihongyan1 lihongyan1

@Tai-RedHat Tai-RedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/network-attachment-definition Related to network-attachment-definition do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet