Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add extension point to enable customized create project modal for dynamic plugins #13825

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented May 6, 2024

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 6, 2024
@TheRealJon
Copy link
Member

I just realized that we probably need to change the existing createNamespaceModal, createProjectModal, and createNamespaceOrProjectModal functions to use the useModal hook from the dynamic plugin SDK. The createModalLauncher function, part of our internal app, passes a different set of props than the launcher returned by useModal. We will want the new extension point to use props from the stable SDK API, not from our internal app.

@TheRealJon
Copy link
Member

I just realized that we probably need to change the existing createNamespaceModal, createProjectModal, and createNamespaceOrProjectModal functions to use the useModal hook from the dynamic plugin SDK. The createModalLauncher function, part of our internal app, passes a different set of props than the launcher returned by useModal. We will want the new extension point to use props from the stable SDK API, not from our internal app.

This also means that these functions will need to be migrated to hooks

@sg00dwin sg00dwin force-pushed the create-project-extension-CONSOLE-3792 branch from 773aa8f to 5842dcb Compare May 22, 2024 19:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels May 22, 2024
@sg00dwin sg00dwin force-pushed the create-project-extension-CONSOLE-3792 branch from 5842dcb to 01ed48b Compare May 24, 2024 18:01
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sg00dwin
Once this PR has been reviewed and has the lgtm label, please assign rohitkrai03 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 24, 2024

@sg00dwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 01ed48b link true /test images
ci/prow/frontend 01ed48b link true /test frontend
ci/prow/e2e-gcp-console 01ed48b link true /test e2e-gcp-console
ci/prow/backend 01ed48b link true /test backend
ci/prow/analyze 01ed48b link true /test analyze

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants