Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32632: Improve Pipeline list page performance #13842

Merged

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32632

Analysis / Root cause:
All TaskRuns were fetched for particular namespace. Due to this many API calls were happening and performance becoming slow.

Solution Description:
Only fetching TaskRuns for the Cancelled PipelineRuns. For other status, TaskRuns status will be calculated from the message value in pipelinerun.status.conditions. Only on click of Failed status to see the logs TaskRuns are fetched for that PipelineRun

Screen shots / Gifs for design review:

Screen.Recording.2024-05-13.at.12.21.00.PM.mov

Unit test coverage report:
NA

Test setup:

1.Create 1000 Pipelines using https://github.com/openshift-dev-console/loadtests and test different scenarios 

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 13, 2024
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32632, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32632

Analysis / Root cause:
All TaskRuns were fetched for particular namespace. Due to this many API calls were happening and performance becoming slow.

Solution Description:
Only fetching TaskRuns for the Cancelled PipelineRuns. For other status, TaskRuns status will be calculated from the message value in pipelinerun.status.conditions. Only on click of Failed status to see the logs TaskRuns are fetched for that PipelineRun

Screen shots / Gifs for design review:

Screen.Recording.2024-05-13.at.12.21.00.PM.mov

Unit test coverage report:
NA

Test setup:

1.Create 1000 Pipelines using https://github.com/openshift-dev-console/loadtests and test different scenarios

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak May 13, 2024 07:10
@lokanandaprabhu
Copy link
Contributor Author

/cc @jerolimov @vikram-raj

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024
@lokanandaprabhu
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-32632, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lokanandaprabhu
Copy link
Contributor Author

/retest

1 similar comment
@lokanandaprabhu
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9d15ca4 and 2 for PR HEAD caf6940 in total

Copy link
Contributor

openshift-ci bot commented May 22, 2024

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8fbdf6c into openshift:master May 22, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@lokanandaprabhu: Jira Issue OCPBUGS-32632: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-32632 has not been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-32632

Analysis / Root cause:
All TaskRuns were fetched for particular namespace. Due to this many API calls were happening and performance becoming slow.

Solution Description:
Only fetching TaskRuns for the Cancelled PipelineRuns. For other status, TaskRuns status will be calculated from the message value in pipelinerun.status.conditions. Only on click of Failed status to see the logs TaskRuns are fetched for that PipelineRun

Screen shots / Gifs for design review:

Screen.Recording.2024-05-13.at.12.21.00.PM.mov

Unit test coverage report:
NA

Test setup:

1.Create 1000 Pipelines using https://github.com/openshift-dev-console/loadtests and test different scenarios

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/cherry-pick release-4.16 release-4.15

@openshift-cherrypick-robot

@lokanandaprabhu: new pull request created: #13882

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405212243.p0.g8fbdf6c.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/pipelines Related to pipelines-plugin jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants