Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1683: Use go workspaces #3980

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

muraee
Copy link
Contributor

@muraee muraee commented May 3, 2024

What this PR does / why we need it:
This solves 2 problems which were introduced when we moved our API to a separate sub module:

  1. Duplicate API files: currently all our API is vendored in the main module.
  2. API imports in our code are using the vendored version which led to poor UX because local changes to the API are not being reflected immediately in the code until the vendor dir is updated. Also using the IDE "go to" feature will send you to the vendor folder where you can't do any updates/changes.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2024
@openshift-ci-robot
Copy link

@muraee: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
This solves 2 problems which were introduced when we moved our API to a separate sub module:

  1. Duplicate API files: currently all our API is vendored in the main module.
  2. API imports in our code are using the vendored version which led poor UX because local changes to the API is not being reflected immediately in the code until the vendor dir is updated. Also using the IDE "go to" feature will send you the vendor folder where you can't do any updates/changes.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki May 3, 2024 12:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@muraee
Copy link
Contributor Author

muraee commented May 3, 2024

/hold
requires golang-1.22 base image registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.22-openshift-4.17 which we can use after the Branch Cut

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels May 22, 2024
@muraee muraee force-pushed the use-go-workspaces branch 3 times, most recently from d483460 to 5dfeed4 Compare May 22, 2024 14:18
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 22, 2024
@muraee
Copy link
Contributor Author

muraee commented May 22, 2024

/retest-required

@muraee muraee changed the title NO-JIRA: Use go workspaces HOSTEDCP-1683: Use go workspaces May 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2024

@muraee: This pull request references HOSTEDCP-1683 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
This solves 2 problems which were introduced when we moved our API to a separate sub module:

  1. Duplicate API files: currently all our API is vendored in the main module.
  2. API imports in our code are using the vendored version which led to poor UX because local changes to the API are not being reflected immediately in the code until the vendor dir is updated. Also using the IDE "go to" feature will send you to the vendor folder where you can't do any updates/changes.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
@muraee muraee force-pushed the use-go-workspaces branch 3 times, most recently from b4c97f9 to 2fe0358 Compare May 27, 2024 08:38
@muraee muraee force-pushed the use-go-workspaces branch 2 times, most recently from ce002ae to e0e589b Compare May 29, 2024 07:54
Copy link

netlify bot commented May 29, 2024

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit dede986
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6656ebebc2d7d70008de088f
😎 Deploy Preview https://deploy-preview-3980--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@muraee
Copy link
Contributor Author

muraee commented May 29, 2024

/retest ci/prow/e2e-aws

Copy link
Contributor

openshift-ci bot commented May 29, 2024

@muraee: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-kubevirt-aws-ovn
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-metrics
  • /test e2e-azure
  • /test e2e-conformance
  • /test e2e-ibmcloud-iks
  • /test e2e-ibmcloud-roks
  • /test e2e-kubevirt-azure-ovn
  • /test e2e-kubevirt-metal-conformance
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-azure
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-azure-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify

In response to this:

/retest ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@muraee
Copy link
Contributor Author

muraee commented May 29, 2024

/test e2e-aws

@muraee
Copy link
Contributor Author

muraee commented May 29, 2024

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muraee
Copy link
Contributor Author

muraee commented May 29, 2024

/test e2e-aws

Copy link
Contributor

openshift-ci bot commented May 29, 2024

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks dede986 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks dede986 link false /test e2e-ibmcloud-roks
ci/prow/e2e-azure dede986 link false /test e2e-azure
ci/prow/e2e-kubevirt-azure-ovn dede986 link false /test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants