-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTIARCH-4668: Add how to doc for heterogeneous node pools on Agent platform #3991
MULTIARCH-4668: Add how to doc for heterogeneous node pools on Agent platform #3991
Conversation
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b1ddc7c
to
6c89f0e
Compare
abb4245
to
6d842a1
Compare
6d842a1
to
62a0035
Compare
@dharaneeshvrd: This pull request references MULTIARCH-4668 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few grammatical nits and a couple of questions; otherwise, looks good to me.
# Create Heterogeneous NodePools on Agent HostedClusters | ||
|
||
This document explains how to create heterogeneous nodepools on agent platform. | ||
Please [refer](create-agent-cluster.md) to set up the env for agent cluster, this document only covers the things you need to configure to have heterogeneous node pools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please [refer](create-agent-cluster.md) to set up the env for agent cluster, this document only covers the things you need to configure to have heterogeneous node pools. | |
Please [refer](create-agent-cluster.md) to set up the env for agent cluster, this document only covers the things you need to configure to have heterogeneous nodepools. |
~~~sh | ||
export DB_VOLUME_SIZE="10Gi" | ||
export FS_VOLUME_SIZE="10Gi" | ||
export OCP_VERSION="4.15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be 4.16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.16 stable ISOs not released yet, wanted to document the stable one, hence mentioned 4.15.
## Configure DNS | ||
|
||
`*.apps.<cluster_name>` record can be pointed to either one of the worker node where ingress application is hosted, or if you are able to set up a load balancer on top of the worker nodes, point this record to this load balancer. | ||
When you are creating heterogeneous node pool, please make sure the workers are reachable from each other or keep them in the same network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you are creating heterogeneous node pool, please make sure the workers are reachable from each other or keep them in the same network. | |
When you are creating heterogeneous nodepool, please make sure the workers are reachable from each other or keep them in the same network. |
|
||
## Create a Hosted Cluster | ||
|
||
Need to use multi arch release image while creating the cluster to use heterogeneous node pools. Find the latest multi arch images from [here](https://multi.ocp.releases.ci.openshift.org) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use multi arch release image while creating the cluster to use heterogeneous node pools. Find the latest multi arch images from [here](https://multi.ocp.releases.ci.openshift.org) | |
Need to use multi arch release image while creating the cluster to use heterogeneous nodepools. Find the latest multi arch images from [here](https://multi.ocp.releases.ci.openshift.org) |
export HOSTED_CONTROL_PLANE_NAMESPACE="${CLUSTERS_NAMESPACE}-${HOSTED_CLUSTER_NAME}" | ||
export BASEDOMAIN="krnl.es" | ||
export PULL_SECRET_FILE=$PWD/pull-secret | ||
export OCP_RELEASE=4.15.0-multi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be 4.16?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered in other question.
image: quay.io/openshift-release-dev/ocp-release:${OCP_RELEASE} | ||
replicas: 0 | ||
~~~ | ||
This will create node pool of architecture `ppc64le` with 0 replicas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will create node pool of architecture `ppc64le` with 0 replicas. | |
This will create nodepool of architecture `ppc64le` with 0 replicas. |
|
||
## Create Infraenv | ||
|
||
For heterogeneous node pools, need to create infraenv for each architecture you are going to have it in your HCP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For heterogeneous node pools, need to create infraenv for each architecture you are going to have it in your HCP. | |
For heterogeneous nodepools, you need to create infraenv for each architecture you are going to have in your HCP. |
## Create Infraenv | ||
|
||
For heterogeneous node pools, need to create infraenv for each architecture you are going to have it in your HCP. | ||
i.e. Heterogeneous node pools with x86_64 and ppc64le architecture, need to create two infraenv with both architecture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. Heterogeneous node pools with x86_64 and ppc64le architecture, need to create two infraenv with both architecture. | |
i.e. for heterogeneous nodepools with x86_64 and ppc64le architectures, you will need to create two infraenv with both architectures. |
|
||
## Scale the NodePool | ||
|
||
Once your agents are approved, you can scale the node pools. `agentLabelSelector` configured in node pool ensures that only matching agents gets added to the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once your agents are approved, you can scale the node pools. `agentLabelSelector` configured in node pool ensures that only matching agents gets added to the cluster. | |
Once your agents are approved, you can scale the nodepools. `agentLabelSelector` configured in nodepool ensures that only matching agents gets added to the cluster. |
## Scale the NodePool | ||
|
||
Once your agents are approved, you can scale the node pools. `agentLabelSelector` configured in node pool ensures that only matching agents gets added to the cluster. | ||
This will help in descaling the node pool as well, when you want to remove a specific arch nodes from the cluster, you can descale the respective node pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will help in descaling the node pool as well, when you want to remove a specific arch nodes from the cluster, you can descale the respective node pool. | |
This will help in descaling the nodepool as well, when you want to remove a specific arch nodes from the cluster, you can descale the respective nodepool. |
dfc61eb
to
b7650c8
Compare
@bryan-cox addressed your comments, ptal now! |
/approve |
/cc @mkumatag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, lgtm otherwise !
sshAuthorizedKey: ${SSH_PUB_KEY} | ||
EOF | ||
~~~ | ||
This will create two infraenv with x86_64 & ppc64le architectures. Before creating this, need to ensure respective architecture's OS image is added in `AgentServiceConfig` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will create two infraenv with x86_64 & ppc64le architectures. Before creating this, need to ensure respective architecture's OS image is added in `AgentServiceConfig` | |
This will create two infraenvs with x86_64 & ppc64le architectures. Before creating this, need to ensure respective architecture's OS image is added in `AgentServiceConfig` |
## Create Infraenv | ||
|
||
For heterogeneous nodepools, you need to create infraenv for each architecture you are going to have in your HCP. | ||
i.e. for heterogeneous nodepools with x86_64 and ppc64le architecture, you will need to create two infraenv with both architectures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. for heterogeneous nodepools with x86_64 and ppc64le architecture, you will need to create two infraenv with both architectures. | |
i.e. for heterogeneous nodepools with x86_64 and ppc64le architecture, you will need to create two infraenvs with both architectures. |
## Scale the NodePool | ||
|
||
Once your agents are approved, you can scale the nodepools. `agentLabelSelector` configured in nodepool ensures that only matching agents gets added to the cluster. | ||
This will help in descaling the nodepool as well, when you want to remove a specific arch nodes from the cluster, you can descale the respective nodepool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will help in descaling the nodepool as well, when you want to remove a specific arch nodes from the cluster, you can descale the respective nodepool. | |
This also aids in descaling the nodepool. To remove specific arch nodes from the cluster, you can descale the corresponding nodepool. |
@srivastav-abhishek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
b7650c8
to
f1331be
Compare
@srivastav-abhishek comments addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/cc @mkumatag
@srivastav-abhishek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest-required |
@dharaneeshvrd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, dharaneeshvrd, mkumatag, srivastav-abhishek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist