-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33060: enable audit log for oauth-openshift #3994
base: main
Are you sure you want to change the base?
OCPBUGS-33060: enable audit log for oauth-openshift #3994
Conversation
@heliubj18: This pull request references Jira Issue OCPBUGS-33060, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: heliubj18 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a54adbd
to
19f0cd2
Compare
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/jira refresh |
@heliubj18: This pull request references Jira Issue OCPBUGS-33060, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@heliubj18: This pull request references Jira Issue OCPBUGS-33060, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
control-plane-operator/controllers/hostedcontrolplane/oauth/deployment_test.go
Outdated
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/oauth/deployment.go
Show resolved
Hide resolved
19f0cd2
to
5db4b5a
Compare
/jira refresh |
@heliubj18: This pull request references Jira Issue OCPBUGS-33060, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@stevekuznetsov I checked the Konflux failed tasks, and I don't think they are related to my changes. The failures seem to be related to image builds (pp64le) |
Yep, those are fairly common and not actionable other than to /retest |
/lgtm |
/label qe-approved |
@stevekuznetsov could you approve it? thanks! |
@heliubj18 You may want to rebase to pull in #3972 hypershift/control-plane-operator/controllers/hostedcontrolplane/kas/deployment.go Lines 970 to 986 in 82df7b3
hypershift/control-plane-operator/controllers/hostedcontrolplane/kas/deployment.go Lines 239 to 247 in 82df7b3
|
control-plane-operator/controllers/hostedcontrolplane/oauth/deployment.go
Show resolved
Hide resolved
5db4b5a
to
ab3c1fd
Compare
ab3c1fd
to
3c30290
Compare
/retest |
@heliubj18: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@rtheis rebase done, could you please help to review it again? thanks! |
@stevekuznetsov e2e failed again, but I checked the failure, it is about nodepool e2e test. It seems it is not related to this pr. But I don't know how to fix that. |
What this PR does / why we need it:
It enables audit logs for
oauth-openshift
.Currently, hypershift only supports audit logs for
kube-apiserver
,openshift-apiserver
, andopenshift-oauth-apiserver
. However,oauth-openshift
also supports audit logs in standalone OCP.Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes # OCPBUGS-33060
Checklist