HOSTEDCP-1570: remove liveness and readiness probes using metrics endpoint

[jared-hayes-dev]

What this PR does / why we need it:

Removes liveness and readiness probes from cluster-image-registry-operator and ingress-operator This change was discussed in the project-hypershift slack channel. Should probes be desired, upstream operator teams should introduce health endpoints for their respective components. Hypershift should not rely on metrics endpoint as a stop gap for the probes endpoints.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

Hi @jared-hayes-dev. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rtheis]

/ok-to-test

[stevekuznetsov]

@jared-hayes-dev looks good - hate to ask for paperwork, but I think we need a Jira to track this change.

[rtheis]

/lgtm

[jared-hayes-dev]

@stevekuznetsov Here is Jira, I couldn't find any documentation about how to best create this issue if any changes are needed for the ticket please let me know.
https://issues.redhat.com/browse/HOSTEDCP-1570

[rtheis]

/retitle HOSTEDCP-1570: remove liveness and readiness probes using metrics endpoint

[openshift-ci-robot]

@jared-hayes-dev: This pull request references HOSTEDCP-1570 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Removes liveness and readiness probes from cluster-image-registry-operator and ingress-operator This change was discussed in the project-hypershift slack channel. Should probes be desired, upstream operator teams should introduce health endpoints for their respective components. Hypershift should not rely on metrics endpoint as a stop gap for the probes endpoints.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jeffnowicki]

/jira refresh

[openshift-ci-robot]

@jeffnowicki: This pull request references HOSTEDCP-1570 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rtheis]

/test e2e-azure

[rtheis]

/test e2e-azure

[stevekuznetsov]

/lgtm
/assign @sjenning

[bryan-cox]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 597b804 and 0 for PR HEAD 511ae86 in total

[openshift-ci-robot]

/hold

Revision 511ae86 was retested 3 times: holding

[rtheis]

/remove-hold

[rtheis]

@jared-hayes-dev please try rebasing your PR. A rebase may be needed to fix test failures.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 597b804 and 2 for PR HEAD 511ae86 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD af0dd13 and 1 for PR HEAD 511ae86 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d5b642b and 0 for PR HEAD 511ae86 in total

[openshift-ci-robot]

/hold

Revision 511ae86 was retested 3 times: holding

[rtheis]

/lgtm

[rtheis]

/remove-hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jared-hayes-dev, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d5b642b and 2 for PR HEAD be9379e in total

[jared-hayes-dev]

/retest-required

[openshift-ci]

@jared-hayes-dev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	be9379e	link	false	/test e2e-azure
ci/prow/e2e-kubevirt-azure-ovn	be9379e	link	false	/test e2e-kubevirt-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rtheis]

/cherry-pick release-4.16

[rtheis]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@rtheis: #4001 failed to apply on top of branch "release-4.15":

Applying: remove liveness and readiness probes that use the metrics endpoint from ingress and registry operators
Using index info to reconstruct a base tree...
M	control-plane-operator/controllers/hostedcontrolplane/ingressoperator/ingressoperator.go
M	control-plane-operator/controllers/hostedcontrolplane/registryoperator/reconcile.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane-operator/controllers/hostedcontrolplane/registryoperator/reconcile.go
CONFLICT (content): Merge conflict in control-plane-operator/controllers/hostedcontrolplane/registryoperator/reconcile.go
Auto-merging control-plane-operator/controllers/hostedcontrolplane/ingressoperator/ingressoperator.go
CONFLICT (content): Merge conflict in control-plane-operator/controllers/hostedcontrolplane/ingressoperator/ingressoperator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 remove liveness and readiness probes that use the metrics endpoint from ingress and registry operators
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@rtheis: new pull request created: #4116

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rtheis]

@jared-hayes-dev you will need to do a manual cherry-pick to release-4.15 branch.