Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] NO-JIRA: Bump k8s.io/code-generator to 0.30 in hack/tools #4009

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdbooth
Copy link

@mdbooth mdbooth commented May 9, 2024

馃毃DO NOT MERGE馃毃
Requires a go bump to 1.22 in hack/tools which we can't build in OpenShift yet. This is for reference only.

k8s 0.30 includes a substantial re-architect of code-generator. In particular it no longer relies on GOPATH, which allows the workaround in hack/update-codegen.sh to be removed.

Results in a single diff in generated code:

diff --git a/client/applyconfiguration/hypershift/v1beta1/agentnodepoolplatform.go b/client/applyconfiguration/hypershift/v1beta1/agentnodepoolplatform.go    
index abc9f249b..0b66474e8 100644
--- a/client/applyconfiguration/hypershift/v1beta1/agentnodepoolplatform.go
+++ b/client/applyconfiguration/hypershift/v1beta1/agentnodepoolplatform.go
@@ -18,13 +18,13 @@ limitations under the License.
 package v1beta1

 import (
-       v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+       v1 "k8s.io/client-go/applyconfigurations/meta/v1"
 )

 // AgentNodePoolPlatformApplyConfiguration represents an declarative configuration of the AgentNodePoolPlatform type for use
 // with apply.
 type AgentNodePoolPlatformApplyConfiguration struct {
-       AgentLabelSelector *v1.LabelSelector `json:"agentLabelSelector,omitempty"`
+       AgentLabelSelector *v1.LabelSelectorApplyConfiguration `json:"agentLabelSelector,omitempty"`
 }

 // AgentNodePoolPlatformApplyConfiguration constructs an declarative configuration of the AgentNodePoolPlatform type for use with
@@ -36,7 +36,7 @@ func AgentNodePoolPlatform() *AgentNodePoolPlatformApplyConfiguration {
 // WithAgentLabelSelector sets the AgentLabelSelector field in the declarative configuration to the given value
 // and returns the receiver, so that objects can be built by chaining "With" function invocations.
 // If called multiple times, the AgentLabelSelector field is set to the value of the last call.
-func (b *AgentNodePoolPlatformApplyConfiguration) WithAgentLabelSelector(value v1.LabelSelector) *AgentNodePoolPlatformApplyConfiguration {
-       b.AgentLabelSelector = &value
+func (b *AgentNodePoolPlatformApplyConfiguration) WithAgentLabelSelector(value *v1.LabelSelectorApplyConfiguration) *AgentNodePoolPlatformApplyConfiguration {
+       b.AgentLabelSelector = value
        return b
 }

This is a substantial re-architect of code-generator. In particular it
no longer relies on GOPATH, which allows the workaround in
hack/update-codegen.sh to be removed.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link

@mdbooth: This pull request explicitly references no jira issue.

In response to this:

馃毃DO NOT MERGE馃毃
Requires a go bump to 1.22 in hack/tools which we can't build in OpenShift yet. This is for reference only.

k8s 0.30 includes a substantial re-architect of code-generator. In particular it no longer relies on GOPATH, which allows the workaround in hack/update-codegen.sh to be removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/ci-tooling Indicates the PR includes changes for CI or tooling labels May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdbooth
Once this PR has been reviewed and has the lgtm label, please assign csrwng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-tooling Indicates the PR includes changes for CI or tooling do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants