HOSTEDCP-1655: Don't Ignore SubnetID and Network Security Group ID flags when values are passed through

[bryan-cox]

What this PR does / why we need it:
Doesn't ignore the SubnetID and Network Security Group ID flags when values are passed in

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1655

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@bryan-cox: This pull request references HOSTEDCP-1655 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Doesn't ignore the SubnetID and Network Security Group ID flags when values are passed in

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1655

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bryan-cox]

/test all

[bryan-cox]

/test all

[bryan-cox]

/retest

[muraee]

if both subnetID and NetworkSecurityGroupID are not set, we are going to call this GetVnetInfoFromVnetID API twice.
I think the check whether to call this API or not should consider both, i.e.:

if len(subnetID) == 0 || len(NetworkSecurityGroupID) == 0 {
  vnet, err := azureutil.GetVnetInfoFromVnetID(ctx, result.VNetID, subscriptionID, azureCreds)

  if len(subnetID) == 0 {
    subnetID = *vnet.Properties.Subnets[0].ID
  }

  if len(NetworkSecurityGroupID) == 0  {
    networkSecurityGroupID = *vnet.Properties.Subnets[0].Properties.NetworkSecurityGroup.ID
  }
}

[bryan-cox]

/test all

[bryan-cox]

/retest

[Patryk-Stefanski]

/lgtm

[bryan-cox]

/retest

[bryan-cox]

/retest

[bryan-cox]

/retest

[openshift-ci]

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	cc58a30	link	false	/test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.