Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1556: Support Priority based expander for cluster-autoscaler #4029

Merged

Conversation

muraee
Copy link
Contributor

@muraee muraee commented May 14, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1556

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024

@muraee: This pull request references HOSTEDCP-1556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1556

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels May 14, 2024
@muraee muraee force-pushed the clusterautoscaler-prio-expander branch from 97de18d to 99cc399 Compare May 14, 2024 10:40
@enxebre
Copy link
Member

enxebre commented May 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@csrwng
Copy link
Contributor

csrwng commented May 17, 2024

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@csrwng: Overrode contexts on behalf of csrwng: Red Hat Konflux / hypershift-operator-main-on-pull-request

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 630c4d8 and 2 for PR HEAD 99cc399 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c698d1d and 1 for PR HEAD 99cc399 in total

@enxebre
Copy link
Member

enxebre commented May 20, 2024

/test e2e-aws

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c5401ca and 0 for PR HEAD 99cc399 in total

@openshift-ci-robot
Copy link

/hold

Revision 99cc399 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@enxebre
Copy link
Member

enxebre commented May 21, 2024

known issue failing kubevirt

    --- FAIL: TestCreateCluster/Teardown (29.55s)
        --- FAIL: TestCreateCluster/Teardown/ValidateMetricsAreExposed (0.04s)
panic: prometheus service account not found [recovered]
	panic: prometheus service account not found

/hold cancel
/override ci/prow/e2e-kubevirt-aws-ovn
/cherry-pick release-4.16

@openshift-cherrypick-robot

@enxebre: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

known issue failing kubevirt

   --- FAIL: TestCreateCluster/Teardown (29.55s)
       --- FAIL: TestCreateCluster/Teardown/ValidateMetricsAreExposed (0.04s)
panic: prometheus service account not found [recovered]
  panic: prometheus service account not found

/hold cancel
/override ci/prow/e2e-kubevirt-aws-ovn
/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
Copy link
Contributor

openshift-ci bot commented May 21, 2024

@enxebre: Overrode contexts on behalf of enxebre: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

known issue failing kubevirt

   --- FAIL: TestCreateCluster/Teardown (29.55s)
       --- FAIL: TestCreateCluster/Teardown/ValidateMetricsAreExposed (0.04s)
panic: prometheus service account not found [recovered]
  panic: prometheus service account not found

/hold cancel
/override ci/prow/e2e-kubevirt-aws-ovn
/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 21, 2024

@muraee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 99cc399 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@muraee
Copy link
Contributor Author

muraee commented May 21, 2024

/override ci/prow/e2e-kubevirt-aws-ovn

Copy link
Contributor

openshift-ci bot commented May 21, 2024

@muraee: Overrode contexts on behalf of muraee: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f20ba0d into openshift:main May 21, 2024
11 of 13 checks passed
@openshift-cherrypick-robot

@enxebre: new pull request created: #4068

In response to this:

known issue failing kubevirt

   --- FAIL: TestCreateCluster/Teardown (29.55s)
       --- FAIL: TestCreateCluster/Teardown/ValidateMetricsAreExposed (0.04s)
panic: prometheus service account not found [recovered]
  panic: prometheus service account not found

/hold cancel
/override ci/prow/e2e-kubevirt-aws-ovn
/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants