Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1882515: bump RHCOS images for Ignition entropy fix #4234

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Oct 1, 2020

This fixes early boot issues in environments with low entropy.

$ ./differ.py \
        --first-endpoint art --first-version 46.82.202009222340-0 \
        --second-endpoint art --second-version 46.82.202010011740-0
{
    "sources": {
        "46.82.202009222340-0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.6/46.82.202009222340-0/x86_64/commitmeta.json",
        "46.82.202010011740-0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.6/46.82.202010011740-0/x86_64/commitmeta.json"
    },
    "diff": {
        "conmon": {
            "46.82.202009222340-0": "conmon-2.0.20-1.rhaos4.6.el8.x86_64",
            "46.82.202010011740-0": "conmon-2.0.21-2.rhaos4.6.el8.x86_64"
        },
        "console-login-helper-messages": {
            "46.82.202009222340-0": "console-login-helper-messages-0.18.2-1.rhaos4.6.el8.noarch",
            "46.82.202010011740-0": "console-login-helper-messages-0.19-1.rhaos4.6.el8.noarch"
        },
        "console-login-helper-messages-issuegen": {
            "46.82.202009222340-0": "console-login-helper-messages-issuegen-0.18.2-1.rhaos4.6.el8.noarch",
            "46.82.202010011740-0": "console-login-helper-messages-issuegen-0.19-1.rhaos4.6.el8.noarch"
        },
        "console-login-helper-messages-profile": {
            "46.82.202009222340-0": "console-login-helper-messages-profile-0.18.2-1.rhaos4.6.el8.noarch",
            "46.82.202010011740-0": "console-login-helper-messages-profile-0.19-1.rhaos4.6.el8.noarch"
        },
        "cri-o": {
            "46.82.202009222340-0": "cri-o-1.19.0-18.rhaos4.6.gitd802e19.el8.x86_64",
            "46.82.202010011740-0": "cri-o-1.19.0-19.rhaos4.6.gitda1d894.el8.x86_64"
        },
        "ignition": {
            "46.82.202009222340-0": "ignition-2.6.0-4.rhaos4.6.git947598e.el8.x86_64",
            "46.82.202010011740-0": "ignition-2.6.0-5.rhaos4.6.git947598e.el8.x86_64"
        },
        "kernel": {
            "46.82.202009222340-0": "kernel-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "kernel-core": {
            "46.82.202009222340-0": "kernel-core-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-core-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "kernel-modules": {
            "46.82.202009222340-0": "kernel-modules-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-modules-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "kernel-modules-extra": {
            "46.82.202009222340-0": "kernel-modules-extra-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-modules-extra-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "openshift-clients": {
            "46.82.202009222340-0": "openshift-clients-4.6.0-202009212020.p0.git.3769.30ffb23.el8.x86_64",
            "46.82.202010011740-0": "openshift-clients-4.6.0-202009302026.p0.git.3788.4b35f95.el8.x86_64"
        },
        "openshift-hyperkube": {
            "46.82.202009222340-0": "openshift-hyperkube-4.6.0-202009221331.p0.git.94008.76307ab.el8.x86_64",
            "46.82.202010011740-0": "openshift-hyperkube-4.6.0-202009292315.p0.git.94026.088ba37.el8.x86_64"
        },
        "podman": {
            "46.82.202009222340-0": "podman-1.9.3-2.rhaos4.6.el8.x86_64",
            "46.82.202010011740-0": "podman-1.9.3-3.rhaos4.6.el8.x86_64"
        },
        "runc": {
            "46.82.202009222340-0": "runc-1.0.0-70.rhaos4.5.gite677e8b.el8.x86_64",
            "46.82.202010011740-0": "runc-1.0.0-81.rhaos4.6.git5b757d4.el8.x86_64"
        }
    }
}

This fixes early boot issues in environments with low entropy.

```
$ ./differ.py \
        --first-endpoint art --first-version 46.82.202009222340-0 \
        --second-endpoint art --second-version 46.82.202010011740-0
{
    "sources": {
        "46.82.202009222340-0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.6/46.82.202009222340-0/x86_64/commitmeta.json",
        "46.82.202010011740-0": "https://releases-rhcos-art.cloud.privileged.psi.redhat.com/storage/releases/rhcos-4.6/46.82.202010011740-0/x86_64/commitmeta.json"
    },
    "diff": {
        "conmon": {
            "46.82.202009222340-0": "conmon-2.0.20-1.rhaos4.6.el8.x86_64",
            "46.82.202010011740-0": "conmon-2.0.21-2.rhaos4.6.el8.x86_64"
        },
        "console-login-helper-messages": {
            "46.82.202009222340-0": "console-login-helper-messages-0.18.2-1.rhaos4.6.el8.noarch",
            "46.82.202010011740-0": "console-login-helper-messages-0.19-1.rhaos4.6.el8.noarch"
        },
        "console-login-helper-messages-issuegen": {
            "46.82.202009222340-0": "console-login-helper-messages-issuegen-0.18.2-1.rhaos4.6.el8.noarch",
            "46.82.202010011740-0": "console-login-helper-messages-issuegen-0.19-1.rhaos4.6.el8.noarch"
        },
        "console-login-helper-messages-profile": {
            "46.82.202009222340-0": "console-login-helper-messages-profile-0.18.2-1.rhaos4.6.el8.noarch",
            "46.82.202010011740-0": "console-login-helper-messages-profile-0.19-1.rhaos4.6.el8.noarch"
        },
        "cri-o": {
            "46.82.202009222340-0": "cri-o-1.19.0-18.rhaos4.6.gitd802e19.el8.x86_64",
            "46.82.202010011740-0": "cri-o-1.19.0-19.rhaos4.6.gitda1d894.el8.x86_64"
        },
        "ignition": {
            "46.82.202009222340-0": "ignition-2.6.0-4.rhaos4.6.git947598e.el8.x86_64",
            "46.82.202010011740-0": "ignition-2.6.0-5.rhaos4.6.git947598e.el8.x86_64"
        },
        "kernel": {
            "46.82.202009222340-0": "kernel-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "kernel-core": {
            "46.82.202009222340-0": "kernel-core-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-core-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "kernel-modules": {
            "46.82.202009222340-0": "kernel-modules-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-modules-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "kernel-modules-extra": {
            "46.82.202009222340-0": "kernel-modules-extra-4.18.0-193.23.1.el8_2.x86_64",
            "46.82.202010011740-0": "kernel-modules-extra-4.18.0-193.24.1.el8_2.dt1.x86_64"
        },
        "openshift-clients": {
            "46.82.202009222340-0": "openshift-clients-4.6.0-202009212020.p0.git.3769.30ffb23.el8.x86_64",
            "46.82.202010011740-0": "openshift-clients-4.6.0-202009302026.p0.git.3788.4b35f95.el8.x86_64"
        },
        "openshift-hyperkube": {
            "46.82.202009222340-0": "openshift-hyperkube-4.6.0-202009221331.p0.git.94008.76307ab.el8.x86_64",
            "46.82.202010011740-0": "openshift-hyperkube-4.6.0-202009292315.p0.git.94026.088ba37.el8.x86_64"
        },
        "podman": {
            "46.82.202009222340-0": "podman-1.9.3-2.rhaos4.6.el8.x86_64",
            "46.82.202010011740-0": "podman-1.9.3-3.rhaos4.6.el8.x86_64"
        },
        "runc": {
            "46.82.202009222340-0": "runc-1.0.0-70.rhaos4.5.gite677e8b.el8.x86_64",
            "46.82.202010011740-0": "runc-1.0.0-81.rhaos4.6.git5b757d4.el8.x86_64"
        }
    }
}
```
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Oct 1, 2020
@openshift-ci-robot
Copy link
Contributor

@jlebon: This pull request references Bugzilla bug 1882515, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882515: bump RHCOS images for Ignition entropy fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 1, 2020
@cgwalters
Copy link
Member

/test e2e-vsphere-upi
/test e2e-vsphere
/test e2e-metal
/test e2e-aws
/test e2e-gcp
/test e2e-azure

@cgwalters
Copy link
Member

e2e-aws: Something wrong in the network operator...

"message": "DaemonSet "openshift-multus/multus" is not available (awaiting 1 nodes)\nDaemonSet "openshift-multus/network-metrics-daemon" is not available (awaiting 1 nodes)\nDaemonSet "openshift-sdn/ovs" is not available (awaiting 1 nodes)\nDaemonSet "openshift-sdn/sdn" is not available (awaiting 1 nodes)",

It looks to me like a worker node didn't come up - worker machineset is missing one. Might warrant further investigation. I don't see anything obvious in the console logs offhand.

e2e-azure & e2e-gcp: test failures, unlikely to be related

e2e-metal: Marketplace operator flake

/test e2e-aws
/test e2e-metal

@lucab
Copy link
Contributor

lucab commented Oct 2, 2020

/retest

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@ashcrow ashcrow requested a review from sdodson October 2, 2020 18:59
@miabbott
Copy link
Member

miabbott commented Oct 2, 2020

/retest

@miabbott
Copy link
Member

miabbott commented Oct 2, 2020

e2e-aws is failing on [k8s.io] [sig-node] Pods Extended [k8s.io] Pod Container Status should never report success for a pending container [Suite:openshift/conformance/parallel] [Suite:k8s] which is linked to a couple of BZs, but most recently https://bugzilla.redhat.com/show_bug.cgi?id=1884697. (Previously linked to https://bugzilla.redhat.com/show_bug.cgi?id=1883343 which is in VERIFIED 🤔 )

e2e-metal failing on [sig-api-machinery][Feature:APIServer][Late] kubelet terminates kube-apiserver gracefully [Suite:openshift/conformance/parallel] linked to https://bugzilla.redhat.com/show_bug.cgi?id=1882111 opened 3 days ago

Neither of those failures appears to be the result of this PR

@cgwalters
Copy link
Member

OK we've got a lot of passing tests here, can someone add a LGTM?

@sdodson
Copy link
Member

sdodson commented Oct 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 5, 2020
@openshift-ci-robot
Copy link
Contributor

@jlebon: This pull request references Bugzilla bug 1882515, which is invalid:

  • expected dependent Bugzilla bug 1778762 to target a release in 4.7.0, but it targets "8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1882515: bump RHCOS images for Ignition entropy fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 5, 2020
@jlebon
Copy link
Member Author

jlebon commented Oct 5, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@jlebon: This pull request references Bugzilla bug 1882515, which is invalid:

  • expected Bugzilla bug 1882515 to depend on a bug targeting a release in 4.7.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon jlebon closed this Oct 5, 2020
@jlebon jlebon reopened this Oct 5, 2020
@openshift-ci-robot
Copy link
Contributor

@jlebon: This pull request references Bugzilla bug 1882515, which is invalid:

  • expected Bugzilla bug 1882515 to depend on a bug targeting a release in 4.7.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1882515: bump RHCOS images for Ignition entropy fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ashcrow, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Oct 5, 2020

Hmm, I think Prow doesn't know that PRs can have their target branch changed? It seems like it still thinks we're targeting master/4.7?

@openshift-ci-robot
Copy link
Contributor

@jlebon: This pull request references Bugzilla bug 1882515. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1882515: bump RHCOS images for Ignition entropy fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlebon
Copy link
Member Author

jlebon commented Oct 5, 2020

/refresh

@jlebon
Copy link
Member Author

jlebon commented Oct 5, 2020

PR for 4.7 is here: #4241
Can someone tell Prow that the RHBZ linked is in order?

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 5, 2020
@cgwalters
Copy link
Member

/retest
Hm looks like some generic Prow failures there in the unit runs.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jlebon
Copy link
Member Author

jlebon commented Oct 6, 2020

Hmm, lots of tests seem stuck? From ci/prow/e2e-aws-upgrade:

Test started yesterday at 9:41 AM is still running after 23h44m17s.

/retest

@sdodson
Copy link
Member

sdodson commented Oct 6, 2020

Looks like job names changed. Anyway, I'll look at overriding things after this round finishes. Lets not do another manual retest.

@sdodson
Copy link
Member

sdodson commented Oct 6, 2020

/skip
To see if it clears the stale job names out

@sdodson
Copy link
Member

sdodson commented Oct 6, 2020

/refresh

@sdodson
Copy link
Member

sdodson commented Oct 7, 2020

/override ci/prow/e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 7, 2020

/override ci/prow/e2e-vsphere-upi
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-gcp-upi-xpn
/override ci/prow/e2e-crc
/override ci/prow/e2e-azure-upi
All of these have passed before.

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-azure-upi, ci/prow/e2e-crc, ci/prow/e2e-gcp-upi-xpn, ci/prow/e2e-metal-ipi, ci/prow/e2e-vsphere-upi

In response to this:

/override ci/prow/e2e-vsphere-upi
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-gcp-upi-xpn
/override ci/prow/e2e-crc
/override ci/prow/e2e-azure-upi
All of these have passed before.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 7, 2020

/override ci/prow/e2e-aws
This has also passed in the past

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws

In response to this:

/override ci/prow/e2e-aws
This has also passed in the past

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 0734b75 into openshift:release-4.6 Oct 7, 2020
@openshift-ci-robot
Copy link
Contributor

@jlebon: All pull requests linked via external trackers have merged:

Bugzilla bug 1882515 has been moved to the MODIFIED state.

In response to this:

Bug 1882515: bump RHCOS images for Ignition entropy fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants