OCPBUGS-31467: Return from EnsureHostInPool on all NIC errors #1964
Conversation
When looking up the NIC, if there's an error, this function should return regardless of the error. The previous code could proceed when an instance wasn't found, and the `nic` would be a nil pointer. Signed-off-by: Nolan Brubaker <nolan@nbrubaker.com>
openshift-ci-robot
added
backports/unvalidated-commits
|
@nrb: This pull request references Jira Issue OCPBUGS-31467, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@nrb: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@nrb: This pull request references Jira Issue OCPBUGS-31467, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@nrb: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoelSpeed, nrb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When looking up the NIC, if there's an error, this function should return regardless of the error.
The previous code could proceed when an instance wasn't found, and the
nicwould be a nil pointer.Carry of kubernetes#124541; that PR may not merge since the Azure cloud provider has been removed from the
masterbranch.The fix is present in https://github.com/kubernetes-sigs/cloud-provider-azure (https://github.com/kubernetes-sigs/cloud-provider-azure/blame/master/pkg/provider/azure_standard.go#L866), but not all customers are using the external provider.
I do not know exactly why this change is not present in k8s/k8s but is in k8s-sigs/cloud-provider-azure. The
git blamefor the relevant line is confusing to me.