OCPBUGS-31365: make verify should use MCO's kube version #4280

djoshy · 2024-03-25T14:55:36Z

- What I did
Hardcoded setup-envtools to a version right before the go bump to 1.22. As a result, this will have to manually updated along with a kube bump to keep up as we will no longer be using the @latest tag

- How to verify it
make verify should pass

djoshy · 2024-03-25T14:55:42Z

/test verify

openshift-ci-robot · 2024-03-25T14:55:43Z

@djoshy: This pull request references Jira Issue OCPBUGS-31365, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
Hardcoded setup-envtools to a version right before the go bump to 1.22. As a result, this will have to manually updated along with a kube bump to keep up as we will no longer be using the @latest tag

- How to verify it
make verify should pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-03-25T14:55:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

djoshy · 2024-03-25T15:02:17Z

/test all

openshift-ci · 2024-03-25T15:03:26Z

@djoshy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 4.12-upgrade-from-stable-4.11-images
/test cluster-bootimages
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op
/test e2e-gcp-op-single-node
/test e2e-hypershift
/test images
/test okd-scos-images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
/test bootstrap-unit
/test e2e-aws-disruptive
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-fips-op
/test e2e-aws-ovn-upgrade-out-of-change
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-single-node
/test e2e-aws-upgrade-single-node
/test e2e-aws-workers-rhel8
/test e2e-azure
/test e2e-azure-ovn-upgrade
/test e2e-azure-ovn-upgrade-out-of-change
/test e2e-azure-upgrade
/test e2e-gcp-op-techpreview
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-rt
/test e2e-gcp-rt-op
/test e2e-gcp-single-node
/test e2e-gcp-upgrade
/test e2e-metal-assisted
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-dualstack
/test e2e-openstack-externallb
/test e2e-openstack-parallel
/test e2e-ovirt
/test e2e-ovirt-upgrade
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-upgrade
/test e2e-vsphere-upi
/test e2e-vsphere-upi-zones
/test e2e-vsphere-zones
/test okd-e2e-aws
/test okd-e2e-gcp-op
/test okd-e2e-upgrade
/test okd-e2e-vsphere
/test okd-images
/test okd-scos-e2e-aws-ovn
/test okd-scos-e2e-gcp-op
/test okd-scos-e2e-gcp-ovn-upgrade
/test okd-scos-e2e-vsphere
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-config-operator-master-bootstrap-unit
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node
pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview
pull-ci-openshift-machine-config-operator-master-e2e-hypershift
pull-ci-openshift-machine-config-operator-master-images
pull-ci-openshift-machine-config-operator-master-okd-images
pull-ci-openshift-machine-config-operator-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-master-okd-scos-images
pull-ci-openshift-machine-config-operator-master-security
pull-ci-openshift-machine-config-operator-master-unit
pull-ci-openshift-machine-config-operator-master-verify

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sinnykumari · 2024-03-25T15:24:22Z

Makefile

 SETUP_ENVTEST := $(shell command -v setup-envtest 2> /dev/null)
 install-setup-envtest:
 ifdef SETUP_ENVTEST
 	@echo "Found setup-envtest"
 else
 	@echo "Installing setup-envtest"
-	go install -mod= sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
+	go install -mod= sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240315194348-5aaf1190f880


Let's add a comment so that we remember to update it instead of carrying over same version in future release

I Should have checked https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest repo earlier . It looks like this repo doesn't have each kube version specific branches. So, let's remove the comment (sorry, should have checked earlier)
As per kubernetes-sigs/controller-runtime@4c2442e Go bump to 1.22 was added because kube 1.30 needs that. We can backport this PR to older version as it is and create a story targeted to 4.17 where we would bump kube to 1.30 to use latest tag.

sinnykumari · 2024-03-25T15:46:57Z

/lgtm

sinnykumari · 2024-03-25T16:00:20Z

/lgtm cancel
#4280 (comment)

sinnykumari · 2024-03-25T16:25:54Z

/lgtm

openshift-ci · 2024-03-25T16:26:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-03-25T19:18:48Z

@djoshy: Jira Issue OCPBUGS-31365: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#4280

Jira Issue OCPBUGS-31365 has been moved to the MODIFIED state.

In response to this:

- What I did
Hardcoded setup-envtools to a version right before the go bump to 1.22. As a result, this will have to manually updated along with a kube bump to keep up as we will no longer be using the @latest tag

- How to verify it
make verify should pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-03-25T19:19:25Z

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-techpreview	`2df1ee1`	link	false	`/test e2e-gcp-op-techpreview`
ci/prow/okd-scos-e2e-aws-ovn	`2df1ee1`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

djoshy · 2024-03-25T19:31:34Z

/cherrypick release-4.15

openshift-cherrypick-robot · 2024-03-25T19:32:22Z

@djoshy: new pull request created: #4282

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2024-03-25T22:53:13Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403251813.p0.gcaeefea.assembly.stream.el8 for distgit ose-machine-config-operator.
All builds following this will include this PR.

openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Mar 25, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 25, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024

openshift-ci bot requested a review from sergiordlr March 25, 2024 14:55

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024

djoshy marked this pull request as ready for review March 25, 2024 15:02

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024

openshift-ci bot requested review from cheesesashimi and jkyros March 25, 2024 15:13

sinnykumari reviewed Mar 25, 2024

View reviewed changes

djoshy force-pushed the verify-test-fix branch from 7b8b283 to f2ca04c Compare March 25, 2024 15:44

openshift-ci bot assigned sinnykumari Mar 25, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024

sinnykumari removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024

Makefile: hardcode version of setup-envtest

2df1ee1

djoshy force-pushed the verify-test-fix branch from f2ca04c to 2df1ee1 Compare March 25, 2024 16:18

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024

openshift-merge-bot bot merged commit caeefea into openshift:master Mar 25, 2024
14 of 17 checks passed

openshift-cherrypick-robot mentioned this pull request Mar 25, 2024

[release-4.15] OCPBUGS-31383: make verify should use MCO's kube version #4282

Merged

djoshy deleted the verify-test-fix branch March 26, 2024 19:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-31365: make verify should use MCO's kube version #4280

OCPBUGS-31365: make verify should use MCO's kube version #4280

djoshy commented Mar 25, 2024

djoshy commented Mar 25, 2024

openshift-ci-robot commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

djoshy commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

sinnykumari Mar 25, 2024

djoshy Mar 25, 2024

sinnykumari Mar 25, 2024

sinnykumari commented Mar 25, 2024

sinnykumari commented Mar 25, 2024 •

edited

sinnykumari commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

openshift-ci-robot commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

djoshy commented Mar 25, 2024

openshift-cherrypick-robot commented Mar 25, 2024

openshift-bot commented Mar 25, 2024

OCPBUGS-31365: make verify should use MCO's kube version #4280

OCPBUGS-31365: make verify should use MCO's kube version #4280

Conversation

djoshy commented Mar 25, 2024

djoshy commented Mar 25, 2024

openshift-ci-robot commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

djoshy commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

sinnykumari Mar 25, 2024

Choose a reason for hiding this comment

djoshy Mar 25, 2024

Choose a reason for hiding this comment

sinnykumari Mar 25, 2024

Choose a reason for hiding this comment

sinnykumari commented Mar 25, 2024

sinnykumari commented Mar 25, 2024 • edited

sinnykumari commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

openshift-ci-robot commented Mar 25, 2024

openshift-ci bot commented Mar 25, 2024

djoshy commented Mar 25, 2024

openshift-cherrypick-robot commented Mar 25, 2024

openshift-bot commented Mar 25, 2024

sinnykumari commented Mar 25, 2024 •

edited