-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-32472: Delete state files on reboot only #4331
base: release-4.14
Are you sure you want to change the base?
[release-4.14] OCPBUGS-32472: Delete state files on reboot only #4331
Conversation
The original kubelet.service definition deletes the cpu and memory manager state files on every kubelet restart. That causes a loss of cpu manager information and new cpu allocations the pods are not expecting. Splitting the kubelet.service into two parts should fix this. - kubelet.service no longer deletes the state files on restart - kubelet-cleanup.service is an oneshot before=kubelet service that only executes once at boot and performs the cleanup after reboot.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-28545 has been cloned as Jira Issue OCPBUGS-32472. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-32472, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold This depends on: openshift/origin#28620 and openshift/kubernetes#1951 |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #4311
/assign MarSik