Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2226: Introduce versioning in auto-node-sizing feature #4363

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sairameshv
Copy link
Member

- What I did
Introducing versioning for the auto-node-sizing feature
- How to verify it
The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature
- Description for the changelog
Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this enhancement
These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc.
Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2024

@sairameshv: This pull request references OCPNODE-2226 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

- What I did
Introducing versioning for the auto-node-sizing feature
- How to verify it
The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature
- Description for the changelog
Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this enhancement
These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc.
Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sairameshv
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Introducing a versioning mechanism in auto-node-sizing feature helps in
updating the recommended values of memory and cpu seamlessly based on
openshift requirements and upstream suggestions.

Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
Updated the auto-node-tuning version to "2" and updated the recommended
system reserved cpu calculation based on the following PR
openshift#4272

Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
@sairameshv sairameshv marked this pull request as ready for review May 30, 2024 09:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@sairameshv
Copy link
Member Author

/assign @harche

Copy link
Contributor

openshift-ci bot commented May 30, 2024

@sairameshv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 4d0502c link true /test e2e-hypershift
ci/prow/e2e-azure-ovn-upgrade-out-of-change 4d0502c link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-single-node 4d0502c link true /test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-techpreview 4d0502c link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants