-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPNODE-2226: Introduce versioning in auto-node-sizing feature #4363
base: master
Are you sure you want to change the base?
Conversation
@sairameshv: This pull request references OCPNODE-2226 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sairameshv The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Introducing a versioning mechanism in auto-node-sizing feature helps in updating the recommended values of memory and cpu seamlessly based on openshift requirements and upstream suggestions. Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
Updated the auto-node-tuning version to "2" and updated the recommended system reserved cpu calculation based on the following PR openshift#4272 Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
/assign @harche |
@sairameshv: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
Introducing versioning for the auto-node-sizing feature
- How to verify it
The presence of
/etc/node-sizing-version.json
file on a node indicates the introduction of versioning in the auto node sizing feature- Description for the changelog
Auto node sizing feature gives recommendations about the
kube reserved
,system reserved
memory and cpus as described in this enhancementThese recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc.
Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters.