Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: OCPBUGS-29067: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP #4367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: OCPBUGS-29067: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP #4367

wants to merge 1 commit into from
+42 −0

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented May 14, 2024 •
edited

- What I did
Added a update-dns-server script that adds DNS servers to /etc/NetworkManager/conf.d/dns-servers.conf. This script is run as part of gcp-update-dns.service which is also added as part of this PR. This service should run when the DNSType on the GCP platform is set to "ClusterHosted".

- How to verify it
Start an IPI Install on GCP with userProvisionedDNS=true

- Description for the changelog
Creates a gcp-update-dns.service that updates DNS configuration when GCP's DNSType is "ClusterHosted"

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sadasu
Once this PR has been reviewed and has the lgtm label, please assign dkhater-redhat for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu sadasu changed the title WIP: Prepend DNS resolver to /etc/resolv.conf for GCP WIP: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP May 16, 2024
@sadasu sadasu force-pushed the custom-dns branch 3 times, most recently from 745b62e to 09b1a30 Compare May 16, 2024 17:19
cybertron
cybertron reviewed May 16, 2024
View reviewed changes
templates/common/gcp/units/gcp-update-dns.service.yaml Outdated Show resolved Hide resolved
templates/common/gcp/files/usr-local-bin-update-dns-server.yaml Outdated
echo "Added by OpenShift" >> /etc/NetworkManager/conf.d/dns-servers.conf
echo "[global-dns-domain-*]" >> /etc/NetworkManager/conf.d/dns-servers.conf
echo "servers=$(ip route get 8.8.8.8 | head -1 | cut -d' ' -f7),169.254.169.254" >> /etc/NetworkManager/conf.d/dns-servers.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're changing DNS settings after NM is running you probably need to restart/reload it to pick up the new values. We've also used "nmcli general reload dns-rc" to force reconfiguration of DNS stuff, but I'm not positive that will do what you need here. It may be less invasive than a complete service restart though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll start with "nmcli general reload dns-rc" and update based on testing.

templates/common/gcp/files/usr-local-bin-update-dns-server.yaml Outdated Show resolved Hide resolved
templates/common/gcp/files/usr-local-bin-update-dns-server.yaml Outdated Show resolved Hide resolved
@sadasu sadasu force-pushed the custom-dns branch 2 times, most recently from 47cc754 to 6d21b37 Compare May 16, 2024 20:31
@sadasu sadasu changed the title WIP: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP OCPBUGS-29067: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP May 16, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 16, 2024
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-29067, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
Added a update-dns-server script that adds DNS servers to /etc/NetworkManager/conf.d/dns-servers.conf. This script is run as part of gcp-update-dns.service which is also added as part of this PR. This service should run when the DNSType on the GCP platform is set to "ClusterHosted".

- How to verify it
Start an IPI Install on GCP with userProvisionedDNS=true

- Description for the changelog
Creates a gcp-update-dns.service that updates DNS configuration when GCP's DNSType is "ClusterHosted"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Contributor Author

sadasu commented May 16, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-29067, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 16, 2024
@sadasu sadasu force-pushed the custom-dns branch 5 times, most recently from c00b188 to 4269c52 Compare May 17, 2024 20:29
@sadasu
Copy link
Contributor Author

sadasu commented May 28, 2024

/test ci/prow/images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@sadasu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.12-upgrade-from-stable-4.11-images
  • /test cluster-bootimages
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test e2e-gcp-op
  • /test e2e-gcp-op-single-node
  • /test e2e-hypershift
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • /test bootstrap-unit
  • /test e2e-aws-disruptive
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-fips-op
  • /test e2e-aws-ovn-upgrade-out-of-change
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-ovn-upgrade
  • /test e2e-azure-ovn-upgrade-out-of-change
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op-techpreview
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-rt
  • /test e2e-gcp-rt-op
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-dualstack
  • /test e2e-openstack-externallb
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test okd-scos-images
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-config-operator-master-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade-out-of-change
  • pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade-out-of-change
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-techpreview
  • pull-ci-openshift-machine-config-operator-master-e2e-hypershift
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-security
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify

In response to this:

/test ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sadasu
Copy link
Contributor Author

sadasu commented May 28, 2024

/test images

@sadasu
Copy link
Contributor Author

sadasu commented May 29, 2024

/test e2e-hypershift

@sadasu sadasu changed the title OCPBUGS-29067: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP WIP: OCPBUGS-29067: Set /etc/NetworkManager/conf.d/dns-servers.conf for GCP May 30, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2024

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-images 4269c52 link false /test okd-images
ci/prow/unit 18ad3e7 link true /test unit
ci/prow/images 18ad3e7 link true /test images
ci/prow/e2e-hypershift 18ad3e7 link true /test e2e-hypershift
ci/prow/e2e-azure-ovn-upgrade-out-of-change 18ad3e7 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-techpreview 18ad3e7 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-gcp-op 18ad3e7 link true /test e2e-gcp-op
ci/prow/e2e-gcp-op-single-node 18ad3e7 link true /test e2e-gcp-op-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron left review comments

@mkowalski mkowalski mkowalski left review comments

@dustymabe dustymabe dustymabe left review comments

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sadasu @openshift-ci-robot @cybertron @mkowalski @dustymabe