-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS#33598: The FROM clauses on Containerfile examples of RHCOS image layering are wrong #75864
base: main
Are you sure you want to change the base?
Conversation
🤖 Tue May 14 15:30:31 - Prow CI generated the docs preview: |
f883ab2
to
1203b8b
Compare
QE LGTM |
@sergiordlr You reviewed the original draft of this documentation. Can you PTAL at these suggested changes? Thank you in advance. |
Thx @mike-nguyen for QA review. |
@mburke5678 @sergiordlr one thing: For this bug fix to be complete, I'd also need this PR to be merged in its own project, because openshift-docs directly import files from it: openshift/rhcos-image-layering-examples#18 ... unless we revisit whether we should be importing files from other repos. |
Examples PR merged. Retesting to see if I can re-generate docs preview. /retest |
/retest |
…age layering are wrong Fixed the format of the rhel-coreos base image on the `FROM` clauses of the examples.
I had to do and undo some dummy changes to be able to force-push again (same final content) and re-trigger the preview generation |
@palonsoro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Ok. It is now correct. @mike-nguyen not sure if you would like to have another quick look. When you checked, some of the examples in the older repo were not up-to-date. Now they are. Also looking forward for @sergiordlr feedback. Thanks in advance to everybody! |
Fixed the format of the rhel-coreos base image on
the
FROM
clauses of the examples.Version(s):
4.12+
Issue:
https://issues.redhat.com/browse/OCPBUGS-33598
Link to docs preview:
(pending)
QE review:
Additional information:
(none)