Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS#33598: The FROM clauses on Containerfile examples of RHCOS image layering are wrong #75864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

palonsoro
Copy link
Contributor

Fixed the format of the rhel-coreos base image on
the FROM clauses of the examples.

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-33598

Link to docs preview:
(pending)

QE review:

  • QE has approved this change.

Additional information:
(none)

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 13, 2024

🤖 Tue May 14 15:30:31 - Prow CI generated the docs preview:

https://75864--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/coreos-layering.html

@palonsoro palonsoro force-pushed the OCPBUGS-33598 branch 2 times, most recently from f883ab2 to 1203b8b Compare May 13, 2024 16:18
@mike-nguyen
Copy link
Member

QE LGTM

@mburke5678
Copy link
Contributor

@sergiordlr You reviewed the original draft of this documentation. Can you PTAL at these suggested changes? Thank you in advance.

@palonsoro
Copy link
Contributor Author

Thx @mike-nguyen for QA review.

@palonsoro
Copy link
Contributor Author

@mburke5678 @sergiordlr one thing: For this bug fix to be complete, I'd also need this PR to be merged in its own project, because openshift-docs directly import files from it: openshift/rhcos-image-layering-examples#18

... unless we revisit whether we should be importing files from other repos.

@palonsoro
Copy link
Contributor Author

Examples PR merged.

Retesting to see if I can re-generate docs preview.

/retest

@palonsoro
Copy link
Contributor Author

/retest

…age layering are wrong

Fixed the format of the rhel-coreos base image on
the `FROM` clauses of the examples.
@palonsoro
Copy link
Contributor Author

palonsoro commented May 14, 2024

I had to do and undo some dummy changes to be able to force-push again (same final content) and re-trigger the preview generation

Copy link

openshift-ci bot commented May 14, 2024

@palonsoro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@palonsoro
Copy link
Contributor Author

Ok. It is now correct.

@mike-nguyen not sure if you would like to have another quick look. When you checked, some of the examples in the older repo were not up-to-date. Now they are.

Also looking forward for @sergiordlr feedback.

Thanks in advance to everybody!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants