CNV#29984: Document auto setting of mem and CPU resource limits #75865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/XS
|
@danielclowers: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
stevsmit
added
peer-review-in-progress
stevsmit
reviewed
May 22, 2024
| @@ -8,5 +8,6 @@ | |||
|
|
|||
| A _resource quota_, defined by the `ResourceQuota` object, imposes restrictions on a namespace that limit the total amount of compute resources that can be consumed by resources within that namespace. | |||
|
|
|||
| The `HyperConverged` custom resource (CR) defines the user configuration for the Containerized Data Importer (CDI). The CPU and memory request and limit values are set to a default value of `0`. | |||
| This ensures that pods created by CDI that do not specify compute resource requirements are given the default values and are allowed to run in a namespace that is restricted with a quota. | |||
| The `HyperConverged` custom resource (CR) defines the user configuration for the Containerized Data Importer (CDI). The CPU and memory request and limit values are set to a default value of `0`. This ensures that pods created by CDI that do not specify compute resource requirements are given the default values and are allowed to run in a namespace that is restricted with a quota. | |||
There was a problem hiding this comment.
With or without an article? You use both; might want parallelism?
Suggested change
| The `HyperConverged` custom resource (CR) defines the user configuration for the Containerized Data Importer (CDI). The CPU and memory request and limit values are set to a default value of `0`. This ensures that pods created by CDI that do not specify compute resource requirements are given the default values and are allowed to run in a namespace that is restricted with a quota. | |
| The `HyperConverged` custom resource (CR) defines the user configuration for the Containerized Data Importer (CDI). The CPU and memory request and limit values are set to a default value of `0`. This ensures that pods created by the CDI that do not specify compute resource requirements are given the default values and are allowed to run in a namespace that is restricted with a quota. |
|
One nit. Gj! |
stevsmit
added
peer-review-done
aldiazRH
pushed a commit
to aldiazRH/openshift-docs
that referenced
this pull request
May 22, 2024
CNV#29984: Document auto setting of mem and CPU resource limits
|
/cherry-pick enterprise-4.16 |
|
@stevsmit: new pull request created: #76369 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
aldiazRH
pushed a commit
to aldiazRH/openshift-docs
that referenced
this pull request
May 22, 2024
CNV#29984: Document auto setting of mem and CPU resource limits
aldiazRH
pushed a commit
to aldiazRH/openshift-docs
that referenced
this pull request
May 22, 2024
CNV#29984: Document auto setting of mem and CPU resource limits
adellape
pushed a commit
to adellape/openshift-docs
that referenced
this pull request
May 22, 2024
CNV#29984: Document auto setting of mem and CPU resource limits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s):
4.16
Issue:
https://issues.redhat.com/browse/CNV-29984
Link to docs preview:
https://75865--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/storage/virt-configuring-cdi-for-namespace-resourcequota.html#virt-about-cpu-and-memory-quota-namespace_virt-configuring-cdi-for-namespace-resourcequota
QE review:
Additional information: