Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-9838: adds audit log policy relnote MicroShift #75867

Merged
merged 1 commit into from May 15, 2024
Merged

OSDOCS-9838: adds audit log policy relnote MicroShift #75867

merged 1 commit into from May 15, 2024

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented May 13, 2024 •
edited

Version(s):
4.16 only

Issue:
OSDOCS-9838

Link to docs preview:
Audit Log policy release note

QE review:

  • QE has approved this change.

Additional information:
Main feature PR

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@ShaunaDiaz: This pull request references OSDOCS-9838 which is a valid jira issue.

In response to this:

Version(s):
4.16 only

Issue:
OSDOCS-9838

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@ShaunaDiaz: This pull request references OSDOCS-9838 which is a valid jira issue.

In response to this:

Version(s):
4.16 only

Issue:
OSDOCS-9838

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Main feature PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@ShaunaDiaz ShaunaDiaz mentioned this pull request May 13, 2024
Merged
2 tasks
@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.16 GA milestone May 13, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 13, 2024 •
edited

🤖 Wed May 15 18:09:29 - Prow CI generated the docs preview:

https://75867--ocpdocs-pr.netlify.app/microshift/latest/microshift_release_notes/microshift-4-16-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@ShaunaDiaz: This pull request references OSDOCS-9838 which is a valid jira issue.

In response to this:

Version(s):
4.16 only

Issue:
OSDOCS-9838

Link to docs preview:
Audit Log policy release note

QE review:

  • QE has approved this change.

Additional information:
Main feature PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon
Copy link
Contributor

copejon commented May 14, 2024

@ShaunaDiaz the changes LGTM. I'll put a hold on this in case it still requires a review of the certificate portion.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@ShaunaDiaz ShaunaDiaz removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@ShaunaDiaz
Copy link
Contributor Author

@copejon TY! CA is reviewed and merged. I just added the link to it. We are solid.

@ShaunaDiaz
Copy link
Contributor Author

@kasturinarra Could you PTAL for QE? TY!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@ShaunaDiaz
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 14, 2024
@ShaunaDiaz
Copy link
Contributor Author

@gangwgr Does this one look OK? TY!

@gangwgr
Copy link

gangwgr commented May 14, 2024

@gangwgr Does this one look OK? TY!

This one is fine from my side

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot

@ShaunaDiaz: This pull request references OSDOCS-9838 which is a valid jira issue.

In response to this:

Version(s):
4.16 only

Issue:
OSDOCS-9838

Link to docs preview:
Audit Log policy release note

QE review:

  • QE has approved this change.

Additional information:
Main feature PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 15, 2024
JoeAldinger
JoeAldinger reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion and a question.

microshift_release_notes/microshift-4-16-release-notes.adoc Outdated Show resolved Hide resolved
@JoeAldinger JoeAldinger added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 15, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz ShaunaDiaz merged commit 2de31d6 into openshift:enterprise-4.16 May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon copejon left review comments

@JoeAldinger JoeAldinger JoeAldinger left review comments

Assignees

@copejon copejon

Labels
branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.16 GA
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @copejon @gangwgr @JoeAldinger