Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-9277-new:State NMState wait-ip parameter in dual-stack network… #75869

Merged
merged 1 commit into from
May 17, 2024
Merged

OSDOCS-9277-new:State NMState wait-ip parameter in dual-stack network… #75869

merged 1 commit into from
May 17, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented May 13, 2024 •
edited

WILL NEED A CHANGE MANAGEMENT NOTIFICATION. After QE approve, I'll send out a CM for 4.12 to 4.15 changes.

Version(s):
4.12 to 4.16

Issue:
OSDOCS-9277

Link to docs preview:
Optional: Deploying with dual-stack networking

  • SME has approved this change.
  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
@dfitzmau dfitzmau force-pushed the OSDOCS-9277-new branch 2 times, most recently from efb49a9 to 320f611 Compare May 13, 2024 16:30
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 13, 2024 •
edited

🤖 Fri May 17 07:59:48 - Prow CI generated the docs preview:

https://75869--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html
https://75869--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_vsphere/ipi/installing-vsphere-installer-provisioned-network-customizations.html

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 15, 2024
cybertron
cybertron reviewed May 16, 2024
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, but otherwise lgtm, thanks!

modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc Outdated Show resolved Hide resolved
@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 16, 2024
rbbratta
rbbratta reviewed May 16, 2024
View reviewed changes
modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc Outdated
@@ -28,6 +28,23 @@ serviceNetwork:
- fd03::/112
----

[IMPORTANT]
====
If you specified an NMState configuration in the `networkConfig` section of your your `install-config.yaml` file , ensure you add `interfaces.wait-ip: ipv4+ipv6` to the NMState YAML file to resolve an issue that prevents your cluster from deploying on a dual-stack network.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double your.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone May 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 17, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rbbratta
Copy link

/lgtm

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 17, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@ShaunaDiaz
Copy link
Contributor

/label peer-review-done

@ShaunaDiaz
Copy link
Contributor

/remove-label peer-review-needed

@ShaunaDiaz
Copy link
Contributor

/lgtm

@ShaunaDiaz
Copy link
Contributor

/remove-label merge-review-needed

@ShaunaDiaz ShaunaDiaz merged commit d3b9ee2 into openshift:main May 17, 2024
3 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.12

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.13

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 17, 2024
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.15

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label May 17, 2024
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: #75869 failed to apply on top of branch "enterprise-4.12":

Applying: OSDOCS-9277-new:State NMState wait-ip parameter in dual-stack networking doc
Using index info to reconstruct a base tree...
M	modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc
CONFLICT (content): Merge conflict in modules/ipi-install-modifying-install-config-for-dual-stack-network.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-9277-new:State NMState wait-ip parameter in dual-stack networking doc
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #76171

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #76172

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #76173

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2024
Merged
@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #76174

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 17, 2024
Merged
@dfitzmau dfitzmau mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron left review comments

@rbbratta rbbratta rbbratta left review comments

Assignees

@rbbratta rbbratta

@ShaunaDiaz ShaunaDiaz

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dfitzmau @ocpdocs-previewbot @rbbratta @ShaunaDiaz @openshift-cherrypick-robot @cybertron