Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-6383: OSSM in clusterwide mode can include ALL cluster projects #75873

Merged
merged 1 commit into from May 20, 2024

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented May 13, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15, 4.14, 4.13, 4.12

Issue:
https://issues.redhat.com/browse/OSSM-6383

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15, 4.14, 4.13, 4.12

Issue:
https://issues.redhat.com/browse/OSSM-6383

Link to docs preview:
https://75873--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-deployment-models.html#ossm-excluding-namespaces-from-cluster-wide-mesh-console_ossm-deployment-models

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title OSSM-6383: OSSM in clusterwide mode can include ALL cluster projects [WIP] OSSM-6383: OSSM in clusterwide mode can include ALL cluster projects May 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@rh-tokeefe rh-tokeefe force-pushed the OSSM-6383 branch 2 times, most recently from 51a8603 to 8df159b Compare May 14, 2024 13:55
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
@rh-tokeefe rh-tokeefe force-pushed the OSSM-6383 branch 3 times, most recently from 0c44bab to c4e825f Compare May 15, 2024 21:15
@rh-tokeefe rh-tokeefe force-pushed the OSSM-6383 branch 2 times, most recently from 876e8ea to f15437a Compare May 16, 2024 15:32
Copy link

@eoinfennessy eoinfennessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..!

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2024

@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s): 4.15, 4.14, 4.13, 4.12

Issue:
https://issues.redhat.com/browse/OSSM-6383

Link to docs preview:
https://75873--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-deployment-models.html#ossm-excluding-namespaces-from-cluster-wide-mesh-console_ossm-deployment-models

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maxwelldb maxwelldb added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 16, 2024
@maxwelldb maxwelldb self-requested a review May 16, 2024 20:05
Copy link

openshift-ci bot commented May 17, 2024

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe
Copy link
Contributor Author

@maxwelldb I've submitted all of the edits and rebased the PR.

@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 17, 2024
@jeana-redhat
Copy link
Contributor

/label merge-review-needed

Hey @rh-tokeefe :) Should I remove the [WIP] title and do-not-merge tag here?

@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 20, 2024
@rh-tokeefe rh-tokeefe changed the title [WIP] OSSM-6383: OSSM in clusterwide mode can include ALL cluster projects OSSM-6383: OSSM in clusterwide mode can include ALL cluster projects May 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@stevsmit stevsmit added lgtm Indicates that a PR is ready to be merged. and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels May 20, 2024
@stevsmit stevsmit merged commit 2282866 into openshift:main May 20, 2024
3 checks passed
@stevsmit
Copy link
Member

/cherry-pick enterprise-4.15

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.14

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.13

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot

@stevsmit: new pull request created: #76256

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #76257

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #76258

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #76259

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.16

@openshift-cherrypick-robot

@stevsmit: new pull request created: #76260

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants