-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-6383: OSSM in clusterwide mode can include ALL cluster projects #75873
Conversation
@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
modules/ossm-excluding-namespaces-from-cluster-wide-mesh-cli.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-excluding-namespaces-from-cluster-wide-mesh-cli.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-excluding-namespaces-from-cluster-wide-mesh-cli.adoc
Outdated
Show resolved
Hide resolved
51a8603
to
8df159b
Compare
0c44bab
to
c4e825f
Compare
modules/ossm-excluding-namespaces-from-cluster-wide-mesh-cli.adoc
Outdated
Show resolved
Hide resolved
876e8ea
to
f15437a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM..!
/label peer-review-needed |
@rh-tokeefe: This pull request references OSSM-6383 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@maxwelldb I've submitted all of the edits and rebased the PR. |
/label merge-review-needed |
Hey @rh-tokeefe :) Should I remove the |
/cherry-pick enterprise-4.15 |
/cherry-pick enterprise-4.14 |
/cherry-pick enterprise-4.13 |
/cherry-pick enterprise-4.12 |
@stevsmit: new pull request created: #76256 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@stevsmit: new pull request created: #76257 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@stevsmit: new pull request created: #76258 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@stevsmit: new pull request created: #76259 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick enterprise-4.16 |
@stevsmit: new pull request created: #76260 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.15, 4.14, 4.13, 4.12
Issue:
https://issues.redhat.com/browse/OSSM-6383
Link to docs preview:
https://75873--ocpdocs-pr.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-deployment-models.html#ossm-excluding-namespaces-from-cluster-wide-mesh-console_ossm-deployment-models
QE review:
Additional information: