Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCIDOCS-300: Incorrect example for dual port NIC in day 1 metal IPI #75887

Merged
merged 1 commit into from May 17, 2024

Conversation

johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented May 13, 2024

Signed-off-by: John Wilkins <jowilkin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Updated configuration from feedback.

Fixes: HCIDOCS-300

See https://issues.redhat.com/browse/HCIDOCS-300 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-300/welcome/index.html

For release(s): 4.13-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Updated configuration from feedback.

Fixes: HCIDOCS-300

See https://issues.redhat.com/browse/HCIDOCS-300 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-300/welcome/index.html

For release(s): 4.13-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024

@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Updated configuration from feedback.

Fixes: HCIDOCS-300

See https://issues.redhat.com/browse/HCIDOCS-300 for additional details.

Preview URL: http://184.23.213.161:8080/HCIDOCS-300/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#configuring-host-dual-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow

For release(s): 4.13-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@johnwilkins
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 13, 2024
@johnwilkins
Copy link
Contributor Author

/cc @jadhaj

@openshift-ci openshift-ci bot requested a review from jadhaj May 13, 2024 19:59
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented May 13, 2024

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxwelldb maxwelldb added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 14, 2024
@maxwelldb maxwelldb self-requested a review May 14, 2024 13:02
Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as far as peer review goes. Still needs QE approval. lgtm.

Note that this is an opportunity to fix the module title--we aren't supposed to use "Optional:" in module titles.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 14, 2024
@maxwelldb maxwelldb added this to the Continuous Release milestone May 14, 2024
@jadhaj
Copy link

jadhaj commented May 16, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 16, 2024

@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Updated configuration from feedback.

Fixes: HCIDOCS-300

See https://issues.redhat.com/browse/HCIDOCS-300 for additional details.

Preview URL: http://184.23.213.161:8080/HCIDOCS-300/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#configuring-host-dual-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow

For release(s): 4.13-4.16
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@johnwilkins
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 16, 2024
@johnwilkins
Copy link
Contributor Author

Note: There is no corresponding module entry for openshift-4.12. The module was introduced in openshift-4.13 as a Technology Preview.

@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 17, 2024
@kcarmichael08
Copy link
Contributor

Consider an update to the title at some point to address @maxwelldb 's comment, but I'll merge this one now.

@kcarmichael08 kcarmichael08 merged commit 1b7f042 into openshift:main May 17, 2024
3 checks passed
@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.13

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.14

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.15

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #76150

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #76151

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #76152

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #76153

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants