-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCIDOCS-300: Incorrect example for dual port NIC in day 1 metal IPI #75887
Conversation
Signed-off-by: John Wilkins <jowilkin@redhat.com>
@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
/cc @jadhaj |
🤖 Mon May 13 20:11:49 - Prow CI generated the docs preview: |
@johnwilkins: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine as far as peer review goes. Still needs QE approval. lgtm.
Note that this is an opportunity to fix the module title--we aren't supposed to use "Optional:" in module titles.
/lgtm |
@johnwilkins: This pull request references HCIDOCS-300 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label merge-review-needed |
Note: There is no corresponding module entry for openshift-4.12. The module was introduced in openshift-4.13 as a Technology Preview. |
Consider an update to the title at some point to address @maxwelldb 's comment, but I'll merge this one now. |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@kcarmichael08: new pull request created: #76150 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: new pull request created: #76151 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: new pull request created: #76152 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kcarmichael08: new pull request created: #76153 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Updated configuration from feedback.
Fixes: HCIDOCS-300
See https://issues.redhat.com/browse/HCIDOCS-300 for additional details.
Preview URL: http://184.23.213.161:8080/HCIDOCS-300/installing/installing_bare_metal_ipi/ipi-install-installation-workflow.html#configuring-host-dual-network-interfaces-in-the-install-config-yaml-file_ipi-install-installation-workflow
For release(s): 4.13-4.16
QE Review:
Signed-off-by: John Wilkins jowilkin@redhat.com