TRT-1576: Fail if operator has Available=False unless in upgrade window #28735
Conversation
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-vsphere-ovn-upgrade This will see if my new exception allows the upgrade job to pass despite the single storage operator replica. |
|
@DennisPeriquet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/272b5a20-0187-11ef-95a0-20b3d6d376a7-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-vsphere-ovn-upgrade retry because the last one didn't really run |
|
@DennisPeriquet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61bc6960-0194-11ef-8313-791cce82a878-0 |
|
Job Failure Risk Analysis for sha: 63d0936
|
DennisPeriquet
force-pushed
the
excepted_failures1
branch
from
63d0936
to
3014822
Compare
|
Job Failure Risk Analysis for sha: 3014822
|
DennisPeriquet
changed the title
|
Job Failure Risk Analysis for sha: d950634
|
|
Job Failure Risk Analysis for sha: 2e4493a
|
|
/test unit |
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-vsphere-ovn-upgrade |
|
@DennisPeriquet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a3d2950-0627-11ef-99cb-168bfde7d9b7-0 |
|
Job Failure Risk Analysis for sha: 80a02e7
|
|
/test unit |
|
/payload-job periodic-ci-openshift-release-master-ci-4.16-e2e-vsphere-ovn-upgrade |
|
@DennisPeriquet: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6ff37c20-0690-11ef-86e4-c1c128b91d20-0 |
DennisPeriquet
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@DennisPeriquet: This pull request references TRT-1576 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@DennisPeriquet: This pull request references TRT-1576 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
DennisPeriquet
force-pushed
the
excepted_failures1
branch
from
696a8b8
to
efde445
Compare
|
Job Failure Risk Analysis for sha: efde445
|
DennisPeriquet
force-pushed
the
excepted_failures1
branch
from
657ec8b
to
89a3143
Compare
|
/test e2e-agnostic-ovn-cmd |
|
/test verify |
|
The single node serial test failed -- but not due to Available=False condition. /test e2e-aws-ovn-single-node-serial |
|
Job Failure Risk Analysis for sha: 0e5fe19
|
|
/test e2e-aws-ovn-single-node-serial |
|
Job Failure Risk Analysis for sha: 438d839
|
|
Job Failure Risk Analysis for sha: 0af0106
|
|
Job Failure Risk Analysis for sha: 0af0106
|
|
/test verify |
|
Job Failure Risk Analysis for sha: 1ca0dc4
|
1 similar comment
|
Job Failure Risk Analysis for sha: 1ca0dc4
|
DennisPeriquet
force-pushed
the
excepted_failures1
branch
2 times, most recently
from
9fd1417
to
52d2c01
Compare
|
Job Failure Risk Analysis for sha: 52d2c01
|
1 similar comment
|
Job Failure Risk Analysis for sha: 52d2c01
|
|
/test e2e-aws-ovn-edge-zones |
|
Job Failure Risk Analysis for sha: 52d2c01
|
DennisPeriquet
force-pushed
the
excepted_failures1
branch
from
52d2c01
to
97f3a73
Compare
|
Job Failure Risk Analysis for sha: 97f3a73
|
|
Job Failure Risk Analysis for sha: 97f3a73
|
|
/test e2e-aws-ovn-edge-zones |
|
Job Failure Risk Analysis for sha: 97f3a73
|
| // For the non-upgrade case, if any operator has Available=False, fail the test. | ||
| if condition.Type == configv1.OperatorAvailable { | ||
|
|
||
| // We'll add an exception for single node for now. |
There was a problem hiding this comment.
Confusing comment I think, says we're adding an exception but we don't actually return the exception, we return empty string and nil which appears to actually mean no exception. I think we then trigger the degraded=True message below as the exception, which isn't even accurate for Available=false.
I would suggest something like:
if condition.Type == configv1.OperatorAvailable && condition.Status == configv1.ConditionFalse {
// We'll add an exception for single node for now.
if isSingleNode {
return "Operators are allowed to go degraded on single-node for now", nil
}
return "", nil
}
| func isSingleNodeCheck(clientConfig *rest.Config) (bool, error) { | ||
| configClient, err := clientconfigv1.NewForConfig(clientConfig) | ||
| if err != nil { | ||
| logrus.Warnf("Error creating config client to check for Single Node configuration: %v", err) |
There was a problem hiding this comment.
log.WithError(err).Error()
|
Job Failure Risk Analysis for sha: 556ee0a
|
|
e2e-gcp-ovn test failure tracked in https://issues.redhat.com/browse/TRT-1680 |
|
/test e2e-aws-ovn-single-node-upgrade |
|
@DennisPeriquet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 556ee0a
|
1 similar comment
|
Job Failure Risk Analysis for sha: 556ee0a
|
For this test:
[bz-%v] clusteroperator/%v should not change condition/Available]:Once the PR where storage operator stops reporting Available status merges, we can remove the exception for it.