Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3775: [WIP] add tests for CMO collection profiles #28768

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

MON-3775: [WIP] add tests for CMO collection profiles #28768

wants to merge 2 commits into from
+52,998 −4,558

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented May 5, 2024 •
edited

The tests cover the following cases:

  • Apply every collection profile, and check if the expected
    ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2024 •
edited by openshift-ci bot

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if appropriate metrics are
    available (or unavailable).
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2024 •
edited by openshift-ci bot

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if the expected
    ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied
    is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection
    profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava rexagod@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod rexagod marked this pull request as ready for review May 5, 2024 23:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2024
@openshift-ci openshift-ci bot requested review from sjenning and soltysh May 5, 2024 23:10
@rexagod rexagod marked this pull request as draft May 6, 2024 01:13
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rexagod rexagod marked this pull request as ready for review May 7, 2024 19:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@openshift-ci openshift-ci bot requested a review from p0lyn0mial May 7, 2024 19:21
@rexagod
MON-3775: add tests for CMO collection profiles
0cb1a87 
The tests cover the following cases:
* Apply every collection profile, and check if the expected
  `ServiceMonitor`s are available.
* CMO configuration reconciliation after a collection profile is applied
  is checked within the CMO tests itself.
* Prometheus `*monitor` selectors' reconciliation after a collection
  profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rexagod rexagod changed the title MON-3775: add tests for CMO collection profiles MON-3775: [WIP] add tests for CMO collection profiles May 7, 2024
@rexagod rexagod marked this pull request as draft May 8, 2024 01:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: e449b02

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
[sig-network-edge][Feature:Idling] Unidling [apigroup:apps.openshift.io][apigroup:route.openshift.io] should handle many TCP connections by possibly dropping those over a certain bound [Serial] [Suite:openshift/conformance/serial]
This test has passed 98.57% of 70 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-serial' 'periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones e449b02 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-fips e449b02 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-single-node-serial e449b02 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-csi e449b02 link false /test e2e-gcp-csi
ci/prow/e2e-gcp-ovn-upgrade e449b02 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-csi e449b02 link false /test e2e-aws-csi
ci/prow/e2e-agnostic-ovn-cmd e449b02 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-openstack-ovn e449b02 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-cgroupsv2 e449b02 link false /test e2e-aws-ovn-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@soltysh soltysh Awaiting requested review from soltysh

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rexagod @openshift-ci-robot @openshift-merge-robot @openshift-trt-bot