Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETCD-488: Fix feature gate for etcd profiles e2e test #28782

Merged
merged 1 commit into from May 13, 2024
Merged

ETCD-488: Fix feature gate for etcd profiles e2e test #28782

merged 1 commit into from May 13, 2024

Conversation

dusk125
Copy link
Contributor

@dusk125 dusk125 commented May 8, 2024

I had the wrong feature gate option so this test wasn't getting scraped properly

@dusk125
Copy link
Contributor Author

dusk125 commented May 8, 2024

/assign @soltysh

@openshift-ci openshift-ci bot requested review from hasbro17 and hexfusion May 8, 2024 16:28
@dusk125 dusk125 force-pushed the etcd-profiles-e2e-gate-fix branch from 59d4824 to 63dc6e7 Compare May 8, 2024 17:51
@dusk125 dusk125 force-pushed the etcd-profiles-e2e-gate-fix branch from 63dc6e7 to 936d007 Compare May 8, 2024 18:55
soltysh
soltysh approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@dusk125
Copy link
Contributor Author

dusk125 commented May 9, 2024

/retest

@soltysh soltysh changed the title [ETCD-488] Fix feature gate for etcd profiles e2e test ETCD-488: Fix feature gate for etcd profiles e2e test May 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot

@dusk125: This pull request references ETCD-488 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

I had the wrong feature gate option so this test wasn't getting scraped properly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@soltysh
Copy link
Member

soltysh commented May 9, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8045e28 and 2 for PR HEAD 936d007 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac69ee5 and 1 for PR HEAD 936d007 in total

@soltysh
Copy link
Member

soltysh commented May 10, 2024

/retest-required

@dusk125
Copy link
Contributor Author

dusk125 commented May 10, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62c5f67 and 0 for PR HEAD 936d007 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2024 •
edited

@dusk125: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 936d007 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 936d007 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 936d007

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-builds Medium
Undiagnosed panic detected in pod
This test has passed 94.74% of 38 runs on release 4.17 [amd64 gcp ha ovn] in the last week.

@soltysh
Copy link
Member

soltysh commented May 13, 2024

/hold cancel

@soltysh
Copy link
Member

soltysh commented May 13, 2024

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d6c3d1c and 2 for PR HEAD 936d007 in total

@openshift-merge-bot openshift-merge-bot bot merged commit fa6c7e6 into openshift:master May 13, 2024
23 of 24 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202405132002.p0.gfa6c7e6.assembly.stream.el9 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@dusk125 dusk125 deleted the etcd-profiles-e2e-gate-fix branch May 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dusk125 @openshift-ci-robot @soltysh @openshift-trt-bot @openshift-bot