Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] hs, kubevirt: Wait node readiness before migration #28784

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

[release-4.14] hs, kubevirt: Wait node readiness before migration #28784

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #28312

/assign qinqon

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 9, 2024
Merged
@openshift-ci openshift-ci bot requested review from nunnatsa and orenc1 May 9, 2024 10:51
@qinqon
hs, kubevirt: Wait node readiness before migration
5b5f0c2 
The test are re-run to check if they are just flaky, in the case of live
migration it should wait for the cluster to settle before doing the live
migration again. This change wait for cluster to reach readiness.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
Copy link
Contributor

qinqon commented May 9, 2024

/lgtm
/approve

@qinqon
Copy link
Contributor

qinqon commented May 9, 2024

/cc @davidvossel

@openshift-ci openshift-ci bot requested a review from davidvossel May 9, 2024 10:52
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@qinqon
Copy link
Contributor

qinqon commented May 9, 2024

/retest-required

davidvossel
davidvossel reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, openshift-cherrypick-robot, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 5b5f0c2 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 5b5f0c2 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-gcp-csi 5b5f0c2 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-serial 5b5f0c2 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd 5b5f0c2 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn 5b5f0c2 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade 5b5f0c2 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-etcd-recovery 5b5f0c2 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@davidvossel davidvossel

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @qinqon @davidvossel