Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-3143: Skip metrics and adjust termination message policy monitor tests #28787

Closed
wants to merge 2 commits into from
Closed

USHIFT-3143: Skip metrics and adjust termination message policy monitor tests #28787

wants to merge 2 commits into from
+18 −1

Conversation

pacevedom
Copy link
Contributor

MicroShift does not support metrics server yet. It is unclear how it will do when it does, so for now skip this test.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024 •
edited by openshift-ci bot

@pacevedom: This pull request references USHIFT-3143 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

MicroShift does not support metrics server yet. It is unclear how it will do when it does, so for now skip this test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and soltysh May 9, 2024 13:56
@pacevedom
Copy link
Contributor Author

/cc @dgoodwin

@openshift-ci openshift-ci bot requested a review from dgoodwin May 9, 2024 22:06
@pacevedom
Copy link
Contributor Author

/retest-required

@pacevedom
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@pacevedom pacevedom changed the title USHIFT-3143: Skip metrics monitor disruption test USHIFT-3143: Skip metrics and termination message policy monitor tests May 10, 2024
@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@dgoodwin
Copy link
Contributor

/lgtm

We need to get a presubmit for microshift in here soon.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ac69ee5 and 2 for PR HEAD 855fe84 in total

@pacevedom
Copy link
Contributor Author

/hold
Need to investigate a thing about these tests.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@pacevedom pacevedom changed the title USHIFT-3143: Skip metrics and termination message policy monitor tests USHIFT-3143: Skip metrics and adjust termination message policy monitor tests May 10, 2024
@pacevedom
Copy link
Contributor Author

/cc @dgoodwin ptal again, I changed one of the tests to allow it to work on MicroShift.

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@pacevedom
Copy link
Contributor Author

/retest-required

1 similar comment
@pacevedom
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa6c7e6 and 2 for PR HEAD cb99e59 in total

@pacevedom
Copy link
Contributor Author

/retest-required

2 similar comments
@pacevedom
Copy link
Contributor Author

/retest-required

@pacevedom
Copy link
Contributor Author

/retest-required

@dgoodwin
Copy link
Contributor

I'm not totally sure what's happening here but I fear your presubmits are stuck running code that was reverted last week. Those panics should have been resolved, and I don't see them firing anywhere else. We've seen this before where PRs get "stuck" on old code and have to be reopened as a new PR. Honestly I think that's what I'd recommend at this point.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: cb99e59

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.67% of 3938 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 Medium
Undiagnosed panic detected in pod
This test has passed 91.67% of 12 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-cgroupsv2'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-csi Medium
Undiagnosed panic detected in pod
This test has passed 97.71% of 2625 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd Medium
Undiagnosed panic detected in pod
This test has passed 97.22% of 72 runs on release 4.17 [amd64 azure ha ovn] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Low
Undiagnosed panic detected in pod
This test has passed 76.47% of 17 runs on release 4.17 [amd64 aws ovn single-node] in the last week.

@pacevedom
Copy link
Contributor Author

/retest-required

@pacevedom
USHIFT-3143: Skip metrics monitor disruption test
d457d73 
MicroShift does not support metrics server yet. It is unclear how it
will do when it does, so for now skip this test.
@pacevedom
USHIFT-3143: Skip termination-message-policy monitor test
c37bbe1 
MicroShift does not support ClusterVersion resources, but this test
only uses it to determine if there were past versions that could skip
the checks due to older versions. Since there is no notion of past
knowledge in MicroShift, adjust the test to not require ClusterVersion.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

New changes are detected. LGTM label has been removed.

@pacevedom pacevedom closed this May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial c37bbe1 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd c37bbe1 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-fips c37bbe1 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacevedom @openshift-ci-robot @dgoodwin @openshift-trt-bot