Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28776 FIX [release-4.15] OCPBUGS-33368: monitor test fix to wait before connecting to a non-existent dns on PowerVS and IBMCloud platforms #28791

Merged
merged 4 commits into from May 16, 2024
Merged

#28776 FIX [release-4.15] OCPBUGS-33368: monitor test fix to wait before connecting to a non-existent dns on PowerVS and IBMCloud platforms #28791

merged 4 commits into from May 16, 2024

Conversation

jcho02
Copy link
Contributor

@jcho02 jcho02 commented May 9, 2024 •
edited

Added logrus to fix #28776 of cherry pic #28739 for release-4.15 branch

jcho02 added 3 commits May 7, 2024 17:44
@jcho02
OCPBUGS-18534: monitor test fix to wait before connecting to a non-ex…
83902d5 
…istent dns

Signed-off-by: Jason Cho <jason.cho2@ibm.com>

go fmt fix

Signed-off-by: Jason Cho <jason.cho2@ibm.com>

add timeout to checkHostnameReady function

Signed-off-by: Jason Cho <jason.cho2@ibm.com>

switch to use oc

Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@jcho02
Use PollUntilContextTimeout instead of deprecated Poll
3e3e8ee 
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@jcho02
add logrus to release-4.15 patch
d94da81 
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 9, 2024
@openshift-ci-robot
Copy link

@jcho02: This pull request references Jira Issue OCPBUGS-33368, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-18534 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-18534 to target a version in 4.16.0, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Added logrus commit on top of #28776 for release-4.15 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and jwforres May 9, 2024 18:33
@jcho02 jcho02 changed the title [release-4.15] OCPBUGS-33368: monitor test fix to wait before connecting to a non-existent dns on PowerVS and IBMCloud platforms FIX #28776 FIX [release-4.15] OCPBUGS-33368: monitor test fix to wait before connecting to a non-existent dns on PowerVS and IBMCloud platforms May 9, 2024
@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/jira refresh

@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-33368, which is invalid:

  • expected dependent Jira Issue OCPBUGS-18534 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-18534 to target a version in 4.16.0, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/jira refresh

@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-33368, which is invalid:

  • expected dependent Jira Issue OCPBUGS-18534 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-18534 to target a version in 4.16.0, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Contributor

neisw commented May 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/retest-required

@Prashanth684 Prashanth684 added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 10, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@jcho02
update backport after #29794 for release-4.15
b464f05 
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/lgtm

@jcho02 jcho02 force-pushed the cherry-pick-28739-to-release-4.15 branch from 26ede39 to b464f05 Compare May 15, 2024 14:13
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@neisw
Copy link
Contributor

neisw commented May 15, 2024

/lgtm

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/jira refresh

@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-33368, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 15, 2024
@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-33368, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-18534 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18534 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @Shilpa-Gokul

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 15, 2024
@openshift-ci openshift-ci bot requested a review from Shilpa-Gokul May 15, 2024 16:42
@prb112
Copy link
Contributor

prb112 commented May 15, 2024

Hey @Shilpa-Gokul could you approve this?

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@jcho02: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery b464f05 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-serial b464f05 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade b464f05 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Shilpa-Gokul
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcho02, neisw, prb112, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shilpa-Gokul
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@Shilpa-Gokul: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Prashanth684
Prashanth684 reviewed May 16, 2024
View reviewed changes
pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
err error
)

wait.PollUntilContextTimeout(ctx, 15*time.Second, 60*time.Minute, true, func(ctx context.Context) (bool, error) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is a one hour timeout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some lbs end up waiting for 45-1hr

@Prashanth684 Prashanth684 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 043979c into openshift:release-4.15 May 16, 2024
21 of 24 checks passed
@openshift-ci-robot
Copy link

@jcho02: Jira Issue OCPBUGS-33368: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33368 has not been moved to the MODIFIED state.

In response to this:

Added logrus to fix #28776 of cherry pic #28739 for release-4.15 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 16, 2024
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202405161507.p0.g043979c.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prashanth684 Prashanth684 Prashanth684 left review comments

@prb112 prb112 prb112 left review comments

@Shilpa-Gokul Shilpa-Gokul Shilpa-Gokul approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@jwforres jwforres Awaiting requested review from jwforres

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@prb112 prb112

@kasturinarra kasturinarra

@jadhaj jadhaj

@neisw neisw

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet