Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28775 FIX [release-4.14] OCPBUGS-33367: monitor test fix to wait before connecting to a non-existent dns on PowerVS and IBMCloud platforms #28792

Open
wants to merge 4 commits into
base: release-4.14
Choose a base branch
from
Open

#28775 FIX [release-4.14] OCPBUGS-33367: monitor test fix to wait before connecting to a non-existent dns on PowerVS and IBMCloud platforms #28792

wants to merge 4 commits into from
+79 −0

Conversation

jcho02
Copy link
Contributor

@jcho02 jcho02 commented May 9, 2024

Added logrus to fix #28775 of Cherry pick #28739 for release 4.14 branch

jcho02 added 3 commits May 7, 2024 17:39
@jcho02
OCPBUGS-18534: monitor test fix to wait before connecting to a non-ex…
46ba79d 
…istent dns

Signed-off-by: Jason Cho <jason.cho2@ibm.com>

go fmt fix

Signed-off-by: Jason Cho <jason.cho2@ibm.com>

add timeout to checkHostnameReady function

Signed-off-by: Jason Cho <jason.cho2@ibm.com>

switch to use oc

Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@jcho02
Use PollUntilContextTimeout instead of deprecated Poll
de591f2 
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@jcho02
add logrus to release-4.14 patch
19bc694 
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 9, 2024
@openshift-ci-robot
Copy link

@jcho02: This pull request references Jira Issue OCPBUGS-33367, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-18534 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-18534 to target a version in 4.15.0, 4.15.z, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Added logrus to fix #28775 of Cherry pick #28739 for release 4.14 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik May 9, 2024 18:37
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

Hi @jcho02. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/jira refresh

@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-33367, which is invalid:

  • expected dependent Jira Issue OCPBUGS-18534 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-18534 to target a version in 4.15.0, 4.15.z, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@neisw
Copy link
Contributor

neisw commented May 9, 2024

/lgtm

@prb112
Copy link
Contributor

prb112 commented May 9, 2024

/retest-required

@Prashanth684 Prashanth684 added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 10, 2024
@jcho02
update backlog after #29794 for release-4.14
a871b82 
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 15, 2024
@openshift-ci openshift-ci bot requested a review from Shilpa-Gokul May 15, 2024 16:44
@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/retest-required

3 similar comments
@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 16, 2024

/retest-required

@Shilpa-Gokul
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcho02, neisw, prb112, Shilpa-Gokul
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgoodwin. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shilpa-Gokul
Copy link
Contributor

/ok-to-test

@Shilpa-Gokul
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@Shilpa-Gokul: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Prashanth684 Prashanth684 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 16, 2024
@prb112
Copy link
Contributor

prb112 commented May 16, 2024

/retest-required

11 similar comments
@prb112
Copy link
Contributor

prb112 commented May 16, 2024

/retest-required

@jcho02
Copy link
Contributor Author

jcho02 commented May 16, 2024

/retest-required

@jcho02
Copy link
Contributor Author

jcho02 commented May 16, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 16, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 17, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 17, 2024

/retest-required

@jcho02
Copy link
Contributor Author

jcho02 commented May 17, 2024

/retest-required

@jcho02
Copy link
Contributor Author

jcho02 commented May 17, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 18, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 19, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 19, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 19, 2024

I did find that another PR faced this issue - #28806

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

@jcho02: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery a871b82 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-serial a871b82 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-agnostic-ovn-cmd a871b82 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-upgrade a871b82 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn a871b82 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-builds a871b82 link true /test e2e-gcp-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prb112
Copy link
Contributor

prb112 commented May 20, 2024

Blocked due to https://issues.redhat.com/browse/OCPBUGS-33486?jql=text%20~%20%22sig-builds%20s2i%22%20ORDER%20BY%20created%20DESC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shilpa-Gokul Shilpa-Gokul Shilpa-Gokul approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dgoodwin dgoodwin

@adambkaplan adambkaplan

@prb112 prb112

@kasturinarra kasturinarra

@jadhaj jadhaj

@neisw neisw

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet