Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: drop ocp-storage exceptions for termination policy #28793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented May 9, 2024

Follow up to #28777

This drops the exceptions that should be fixed by:

openshift/cluster-storage-operator#470
openshift/vmware-vsphere-csi-driver-operator#231
openshift/ibm-vpc-block-csi-driver-operator#114

I'm hoping the presubmit jobs will tell us that they really are fixed.

/cc @deads2k @jsafrane
/test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci openshift-ci bot requested review from deads2k and jsafrane May 9, 2024 21:26
@openshift-ci-robot
Copy link

@dobsonj: This pull request explicitly references no jira issue.

In response to this:

Follow up to #28777

This drops the exceptions that should be fixed by:

openshift/cluster-storage-operator#470
openshift/vmware-vsphere-csi-driver-operator#231
openshift/ibm-vpc-block-csi-driver-operator#114

I'm hoping the presubmit jobs will tell us that they really are fixed.

/cc @deads2k @jsafrane
/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 10, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn da7a899 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade da7a899 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node da7a899 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dobsonj, jsafrane
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants