Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-18534: Pass namespace in function checkHostnameReady for monitortest #28794

Merged
merged 1 commit into from May 14, 2024

Conversation

jcho02
Copy link
Contributor

@jcho02 jcho02 commented May 10, 2024

Patch on #28739

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 10, 2024
@openshift-ci-robot
Copy link

@jcho02: This pull request references Jira Issue OCPBUGS-18534, which is invalid:

  • expected the bug to target only the "4.16.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Patch on #28739

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 10, 2024
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial May 10, 2024 15:28
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2024
Copy link
Contributor

openshift-ci bot commented May 10, 2024

Hi @jcho02. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@prb112
Copy link
Contributor

prb112 commented May 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@neisw
Copy link
Contributor

neisw commented May 10, 2024

/test verify

@prb112
Copy link
Contributor

prb112 commented May 10, 2024

/pr-rehearse ack

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels May 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
Copy link
Contributor

openshift-ci bot commented May 13, 2024

@jcho02: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Shilpa-Gokul
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 37a0c1b

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
[sig-apps] job-upgrade
This test has passed 100.00% of 177 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
This test has passed 99.46% of 2394 runs on release 4.17 [Overall] in the last week.

Open Bugs
Investigate vsphere in-cluster disruption
---
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.54% of 4123 runs on release 4.17 [Overall] in the last week.
---
[sig-node][invariant] alert/TargetDown should not be at or above info in ns/kube-system
This test has passed 99.18% of 4123 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
[sig-network] pods should successfully create sandboxes by adding pod to network
This test has passed 94.22% of 4173 runs on release 4.17 [Overall] in the last week.

Open Bugs
s390x: [sig-network] pods should successfully create sandboxes by adding pod to network fails with error adding pod to CNI network

@neisw
Copy link
Contributor

neisw commented May 13, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcho02, neisw, prb112, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@prb112
Copy link
Contributor

prb112 commented May 13, 2024

/retest-required

@prb112
Copy link
Contributor

prb112 commented May 13, 2024

/jira refresh

@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-18534, which is invalid:

  • expected the bug to target only the "4.16.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@prb112
Copy link
Contributor

prb112 commented May 13, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2024
@openshift-ci-robot
Copy link

@prb112: This pull request references Jira Issue OCPBUGS-18534, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Shilpa-Gokul

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Shilpa-Gokul May 13, 2024 20:11
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa6c7e6 and 2 for PR HEAD 37a0c1b in total

@prb112
Copy link
Contributor

prb112 commented May 14, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@jcho02: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 37a0c1b link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 37a0c1b link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-upgrade 37a0c1b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 37a0c1b link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5f629ff into openshift:master May 14, 2024
19 of 23 checks passed
@openshift-ci-robot
Copy link

@jcho02: Jira Issue OCPBUGS-18534: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18534 has been moved to the MODIFIED state.

In response to this:

Patch on #28739

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202405141619.p0.g5f629ff.assembly.stream.el9 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/cherry-pick release-4.14

@prb112
Copy link
Contributor

prb112 commented May 15, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@prb112: #28794 failed to apply on top of branch "release-4.14":

Applying: Pass namespace in function checkHostnameReady for monitortest
Using index info to reconstruct a base tree...
M	pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
CONFLICT (content): Merge conflict in pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Pass namespace in function checkHostnameReady for monitortest
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@prb112: #28794 failed to apply on top of branch "release-4.15":

Applying: Pass namespace in function checkHostnameReady for monitortest
Using index info to reconstruct a base tree...
M	pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
CONFLICT (content): Merge conflict in pkg/monitortests/network/disruptionserviceloadbalancer/monitortest.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Pass namespace in function checkHostnameReady for monitortest
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jcho02 added a commit to jcho02/origin that referenced this pull request May 15, 2024
Signed-off-by: Jason Cho <jason.cho2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants