Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable multi-arch image builds for openshift/hypershift main branch #51838

Merged
merged 1 commit into from
May 22, 2024
Merged

enable multi-arch image builds for openshift/hypershift main branch #51838

merged 1 commit into from
May 22, 2024

Conversation

droslean
Copy link
Member

@droslean droslean commented May 9, 2024 •
edited

/cc @bear-redhat @openshift/test-platform @bryan-cox

based on https://issues.redhat.com/browse/ART-9592
It seems that the ocp/builder:rhel-9-golang-1.21-ci-build-root-multi-openshift-4.16 is the correct image to be used, containing also the gotestsum binary.

@openshift-ci openshift-ci bot requested review from bear-redhat, bryan-cox and a team May 9, 2024 09:38
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@droslean
Copy link
Member Author

droslean commented May 9, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

droslean commented May 9, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@droslean
Copy link
Member Author

droslean commented May 9, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

droslean commented May 9, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

droslean commented May 9, 2024

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@openshift-ci-robot
Copy link
Contributor

@droslean, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error unmarshaling JSON: json: cannot unmarshal number into Go struct field ImageStreamTagReference.base_images.tag of type string)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@droslean
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
Copy link
Member Author

/retest-required

@droslean
Copy link
Member Author

/test boskos-config-generation
/test check-gh-automation-tide
/test prow-config

@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@LiangquanLi930
Copy link
Member

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@openshift-ci-robot
Copy link
Contributor

@droslean, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
@droslean
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@droslean
enable multi-arch image builds for openshift/hypershift main branch
0d102bb 
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@droslean: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-images openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-main-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-metrics openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-metal-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-okd-scos-images openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-unit openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-verify openshift/hypershift presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@droslean
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024 •
edited

@droslean: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/main/okd-scos-images 23654ba link unknown /pj-rehearse pull-ci-openshift-hypershift-main-okd-scos-images
ci/rehearse/openshift/hypershift/main/e2e-aws-4-13 6e9d0a6 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-4-13
ci/rehearse/openshift/hypershift/main/e2e-aws-metrics 6e9d0a6 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-metrics
ci/rehearse/openshift/hypershift/main/e2e-aws-4-12 6e9d0a6 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-4-12

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@droslean
Copy link
Member Author

/pj-rehearse pull-ci-openshift-hypershift-main-images

@openshift-ci-robot
Copy link
Contributor

@droslean: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiangquanLi930
Copy link
Member

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 77c62a5 into openshift:master May 22, 2024
18 checks passed
@bryan-cox bryan-cox mentioned this pull request May 22, 2024
Merged
@droslean droslean deleted the hyperssss branch May 23, 2024 08:37
@sjenning sjenning mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bear-redhat bear-redhat Awaiting requested review from bear-redhat

@bryan-cox bryan-cox Awaiting requested review from bryan-cox

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
5 participants
@droslean @openshift-ci-robot @bryan-cox @LiangquanLi930 @openshift-merge-robot