Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically choose podman if is present #51849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented May 9, 2024

When podman is installed, use it automatically. User still can set CONTAINER_ENGINE variable to override this, choosing his preferred engine.

/kind enhancement

Copy link
Contributor

openshift-ci bot commented May 9, 2024

@cardil: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

When podman is installed, use it automatically. User still can set CONTAINER_ENGINE variable to override this, choosing his preferred engine.

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from psalajova and Toma5OD May 9, 2024 14:32
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please assign deepsm007 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@cardil: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@cardil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
2 participants