Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRVKP-3342: Add pipelines cluster pool #51872

Merged

Conversation

divyansh42
Copy link
Contributor

@divyansh42 divyansh42 commented May 10, 2024

This PR adds the cluster pool and its required configurations. A follow-up PR will be done to modify the cluster claim test configurations of the different components.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 10, 2024
@openshift-ci openshift-ci bot requested review from hongkailiu and jmguzik May 10, 2024 07:48
@openshift-ci openshift-ci bot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels May 10, 2024
@divyansh42 divyansh42 changed the title Add pipelines cluster pool SRVKP-3342: Add pipelines cluster pool May 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@divyansh42: This pull request references SRVKP-3342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@divyansh42
Copy link
Contributor Author

@savitaashture @jkandasa @khrm Can I please get review on this PR. Thanks.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@divyansh42: This pull request references SRVKP-3342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds the cluster pool and its required configurations. A follow-up PR will be done to modify the cluster claim test configurations of the different components.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@divyansh42 divyansh42 force-pushed the add-pipelines-cluster-pool branch 2 times, most recently from 0ad920d to d1f50cf Compare May 10, 2024 14:09
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@savitaashture
Copy link
Contributor

  • Can we add one more cluster pool yaml for 4.16 as well because Pipeline supported on 4.16 also

@divyansh42
Copy link
Contributor Author

  • Can we add one more cluster pool yaml for 4.16 as well because Pipeline supported on 4.16 also

Sure, will add for 4.16 as well.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@savitaashture
Copy link
Contributor

savitaashture commented May 14, 2024

1.15 OSP supported from 4.14 onwards as per the component matrix http://dashboard.apps.cicd.ospqa.com/product/componentmatrix/
should we add clusterpool for only those versions ??
wdyt @khrm @jkandasa @vdemeester ?

@divyansh42
Copy link
Contributor Author

1.15 OSP supported from 4.14 onwards as per the component matrix http://dashboard.apps.cicd.ospqa.com/product/componentmatrix/ should we add clusterpool for only those versions ?? wdyt @khrm @jkandasa @vdemeester ?

I think that probably makes sense.
When I was adding cluster pools for all the versions, I was under the impression that we would have test jobs for all other versions as well. But while modifying cluster pool in those test jobs, I only see 4.14 related tests.

@divyansh42
Copy link
Contributor Author

@savitaashture Removed 4.12 and 4.13 cluster pool. PTAL.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@savitaashture
Copy link
Contributor

Thank you @divyansh42 🎉

@divyansh42
Copy link
Contributor Author

As per the comment from the CI bot I am tagging @droslean for the approval. @droslean could you please approve the PR? Thank you.
/assign @droslean

Signed-off-by: divyansh42 <diagrawa@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

name: pipelines-openstack-credentials
size: 0
skipMachinePools: true
status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove status

name: pipelines-openstack-credentials
size: 0
skipMachinePools: true
status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for the review @deepsm007 🙂

name: pipelines-openstack-credentials
size: 0
skipMachinePools: true
status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 15, 2024
Signed-off-by: divyansh42 <diagrawa@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@divyansh42: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented May 15, 2024

@divyansh42: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deepsm007
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, divyansh42, khrm, savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 61dad8d into openshift:master May 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
7 participants