New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVKP-3342: Add pipelines cluster pool #51872
SRVKP-3342: Add pipelines cluster pool #51872
Conversation
@divyansh42: This pull request references SRVKP-3342 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@savitaashture @jkandasa @khrm Can I please get review on this PR. Thanks. |
@divyansh42: This pull request references SRVKP-3342 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
0ad920d
to
d1f50cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Sure, will add for 4.16 as well. |
1.15 OSP supported from 4.14 onwards as per the component matrix http://dashboard.apps.cicd.ospqa.com/product/componentmatrix/ |
I think that probably makes sense. |
@savitaashture Removed 4.12 and 4.13 cluster pool. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you @divyansh42 🎉 |
Signed-off-by: divyansh42 <diagrawa@redhat.com>
1168bec
to
b9244c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
name: pipelines-openstack-credentials | ||
size: 0 | ||
skipMachinePools: true | ||
status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove status
name: pipelines-openstack-credentials | ||
size: 0 | ||
skipMachinePools: true | ||
status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks for the review @deepsm007 🙂
name: pipelines-openstack-credentials | ||
size: 0 | ||
skipMachinePools: true | ||
status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
2e04e60
to
14f5702
Compare
14f5702
to
e423582
Compare
Signed-off-by: divyansh42 <diagrawa@redhat.com>
e423582
to
ff065cc
Compare
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@divyansh42: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, divyansh42, khrm, savitaashture, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds the cluster pool and its required configurations. A follow-up PR will be done to modify the cluster claim test configurations of the different components.