Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-3451: openstack: Enable TechPreview testing #51880

Merged
merged 1 commit into from May 15, 2024
Merged

OSASINFRA-3451: openstack: Enable TechPreview testing #51880

merged 1 commit into from May 15, 2024

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented May 10, 2024 •
edited

Remove the existing CAPI jobs that were set up in openshift/installer (which were CustomNoUpgrade) and replace them with TechPreview jobs in shiftstack-ci. Those jobs will exercise the CAPI installer once openshift/installer#8372 merges.

Also set up Slack alerting on these jobs.

For posterity: to add Slack reporting to all jobs that don't have reporting, I have run:

yq --in-place --yaml-output '.periodics |= map(if has("reporter_config") then . else . + {"reporter_config":{"slack":{"channel":"#shiftstack-bot","job_states_to_report":["failure","error"],"report_template":":volcano: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> :volcano:"}}} end)' ci-operator/jobs/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main-periodics.yaml

and then make update to apply formatting in this repo's fashion.

@pierreprinetti pierreprinetti changed the title openstack: Move periodics to shiftstack-ci OSASINFRA-3435: openstack: Move periodics to shiftstack-ci May 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot

@pierreprinetti: This pull request references OSASINFRA-3435 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Also set up Slack alerting.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie and EmilienM May 10, 2024 11:04
@pierreprinetti
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ovn-serial periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ccpmso-zone

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pierreprinetti
Copy link
Member Author

Both jobs installed OpenShift, which means that the CAPI providers are already included in the image.
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 10, 2024
@MaysaMacedo
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@pierreprinetti
Copy link
Member Author

/hold
we must first make sure that shiftstack-ci is scraped by Sippy

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@pierreprinetti
Copy link
Member Author

TODO: use TechPreviewNoUpgrade instead of CustomNoUpgrade+CAPIfeatureSet so that those jobs can become part of our stable jobs.

@pierreprinetti pierreprinetti changed the title OSASINFRA-3435: openstack: Move periodics to shiftstack-ci OSASINFRA-3451: openstack: Enable TechPreview testing May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot

@pierreprinetti: This pull request references OSASINFRA-3451 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Also set up Slack alerting.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pierreprinetti
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024 •
edited by openshift-ci bot

@pierreprinetti: This pull request references OSASINFRA-3451 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 10, 2024
@pierreprinetti
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-techpreview-periodic-4.16-e2e-openstack-ovn-password

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pierreprinetti
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@pierreprinetti
Copy link
Member Author

Once openshift/installer#8372 merges, TechPreview tests will exercise the CAPI-install flow.

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 10, 2024
patrickdillon
patrickdillon reviewed May 13, 2024
View reviewed changes
...onfig/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main__techpreview-periodic-4.16.yaml Outdated
branch: main
org: shiftstack
repo: shiftstack-ci
variant: techpreview-periodic-4.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
variant: techpreview-periodic-4.16
variant: techpreview

Looking at the job names from the rehearsal, e.g.:

periodic-ci-shiftstack-shiftstack-ci-main-techpreview-periodic-4.16-e2e-openstack-proxy 	N/A 	periodic 	Periodic changed

periodic stutters (i.e. it is repeated twice) and 4.16 seems like it might also be redundant (this is for main) or not future proof...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thank you! I am removing "periodic" and I am replacing 4.16 with master, since that's the release image under test here.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2024
@pierreprinetti
openstack: Set up TechPreview jobs
c15de22 
Replace the existing ephemeral CAPI periodics with permanent TechPreview
jobs.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@pierreprinetti: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-dualstack-v6primary N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-additional-ipv6-network N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-csi-manila N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ccpmso N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-nfv-hwoffload N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ovn-serial N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ccpmso-zone N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ovn-password N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-csi-cinder N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-nfv-mellanox N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-nfv-intel N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-fips N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-dualstack N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ovn-parallel N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ovn-etcd-scaling N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-externallb N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-dualstack-upi N/A periodic Periodic changed
periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-proxy N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pierreprinetti
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ccpmso-zone periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ovn-parallel

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 13, 2024

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ccpmso-zone 1268d7f link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ccpmso-zone
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ccpmso-zone c15de22 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-techpreview-master-e2e-openstack-ccpmso-zone

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot

@pierreprinetti: This pull request references OSASINFRA-3451 which is a valid jira issue.

In response to this:

Remove the existing CAPI jobs that were set up in openshift/installer (which were CustomNoUpgrade) and replace them with TechPreview jobs in shiftstack-ci. Those jobs will exercise the CAPI installer once openshift/installer#8372 merges.

Also set up Slack alerting on these jobs.

For posterity: to add Slack reporting to all jobs that don't have reporting, I have run:

yq --in-place --yaml-output '.periodics |= map(if has("reporter_config") then . else . + {"reporter_config":{"slack":{"channel":"#shiftstack-bot","job_states_to_report":["failure","error"],"report_template":":volcano: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> :volcano:"}}} end)' ci-operator/jobs/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main-periodics.yaml

and then make update to apply formatting in this repo's fashion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot

@pierreprinetti: This pull request references OSASINFRA-3451 which is a valid jira issue.

In response to this:

Remove the existing CAPI jobs that were set up in openshift/installer (which were CustomNoUpgrade) and replace them with TechPreview jobs in shiftstack-ci. Those jobs will exercise the CAPI installer once openshift/installer#8372 merges.

Also set up Slack alerting on these jobs.

For posterity: to add Slack reporting to all jobs that don't have reporting, I have run:

yq --in-place --yaml-output '.periodics |= map(if has("reporter_config") then . else . + {"reporter_config":{"slack":{"channel":"#shiftstack-bot","job_states_to_report":["failure","error"],"report_template":":volcano: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> :volcano:"}}} end)' ci-operator/jobs/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main-periodics.yaml

and then make update to apply formatting in this repo's fashion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EmilienM
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@patrickdillon
Copy link
Contributor

/approve

@pierreprinetti
Copy link
Member Author

/assign mandre

mandre
mandre reviewed May 15, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@pierreprinetti
Copy link
Member Author

/assign vrutkovs

vrutkovs
vrutkovs approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mandre, MaysaMacedo, patrickdillon, pierreprinetti, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e232a5a into openshift:master May 15, 2024
18 of 19 checks passed
@pierreprinetti pierreprinetti deleted the os_capi_periodics branch May 15, 2024 10:41
@patrickdillon patrickdillon mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@vrutkovs vrutkovs vrutkovs approved these changes

@bfournie bfournie Awaiting requested review from bfournie

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@vrutkovs vrutkovs

@mandre mandre

@EmilienM EmilienM

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
8 participants
@pierreprinetti @openshift-ci-robot @MaysaMacedo @EmilienM @patrickdillon @vrutkovs @mandre @openshift-merge-robot