cert-rotation: CSR approval fixes #51885
Conversation
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-suspend-90d pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-sno-cert-rotation-suspend-90d |
|
@vrutkovs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
vrutkovs
force-pushed
the
cert-rotation-csr-wait
branch
from
156f3db
to
4bea0cd
Compare
|
/pj-rehearse pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-suspend-90d pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-sno-cert-rotation-suspend-90d |
|
@vrutkovs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
vrutkovs
force-pushed
the
cert-rotation-csr-wait
branch
from
4bea0cd
to
d0ec8e6
Compare
|
/pj-rehearse pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-suspend-90d pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-sno-cert-rotation-suspend-90d |
|
@vrutkovs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
* print when CSR approval is completed. This helps correlate between kubelet logs and csr approval start/end period * extend time we want for new certs. With leader election it takes ~7 minutes for new certs to be generated and distributed, so that kubelet could create CSRs after we finish approval. This extends timeout we wait for bootstrap certs to be approved from 30*10/60 = 5 minutes to 40*15/60 = 10 minutes
vrutkovs
force-pushed
the
cert-rotation-csr-wait
branch
from
d0ec8e6
to
0ffd1d3
Compare
|
/pj-rehearse pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-ha-cert-rotation-suspend-90d pull-ci-openshift-cluster-kube-apiserver-operator-release-4.15-e2e-metal-ovn-sno-cert-rotation-suspend-90d |
|
@vrutkovs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 162 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@vrutkovs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanchezl, vrutkovs, wangke19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-bot
bot
merged commit b24eab6
into
openshift:master
print when CSR approval is completed. This helps correlate between kubelet logs and csr approval start/end period
extend time we want for new certs. With leader election it takes ~7 minutes for new certs to be generated and distributed, so that kubelet could create CSRs after we finish approval.
This extends timeout we wait for bootstrap certs to be approved from 30 * 10 / 60 = 5 minutes to 40 * 10 / 60 ~ 7 minutes