Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3517: Add the GCP CAPI periodic test #51942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barbacbd
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2024

@barbacbd: This pull request references CORS-3517 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@barbacbd
Copy link
Contributor Author

/cc @patrickdillon
/cc @bfournie

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@barbacbd
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Comment on lines 114 to 115
FEATURE_GATES: '["ClusterAPIInstall=true"]'
FEATURE_SET: CustomNoUpgrade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion late last week with the TRT team, I understood that we want to favor testing the TechPreview feature set--not using individual gates like this. So for the goal of this PR, you should check whether GCP Tech Preview tests are present in the release periodics:
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/release/openshift-release-master__nightly-4.16.yaml
and
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/release/openshift-release-master__ci-4.16.yaml

It looks like GCP techpreview jobs are in the ci periodics, but not the nightly periodics. So I believe we want to add the gcp periodics to the nightly config. AWS is also missing from the nightly config, so if you can add that at the same time that would be appreciated.

@barbacbd
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@patrickdillon
Copy link
Contributor

The tech preview periodics should go into the openshift/release config. See https://github.com/openshift/release/pull/51731/files for examples

Soon we can remove this entire altinfra variant

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@barbacbd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-capi-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-ovn-secureboot-capi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-ovn-xpn-capi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-capi-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-secureboot-capi openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-xpn-capi openshift/installer presubmit Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.16-e2e-gcp-ovn-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@barbacbd
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@barbacbd
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-capi-ovn

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@barbacbd
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-ovn-secureboot-capi

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barbacbd, r4f4
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barbacbd
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-byo-network-capi
/pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-xpn-capi

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@barbacbd: job(s): pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-byo-network-capi either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci-robot
Copy link
Contributor

@barbacbd: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

@barbacbd
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-xpn-capi

@openshift-ci-robot
Copy link
Contributor

@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented May 17, 2024

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-installer-master-altinfra-periodics-e2e-gcp-capi-ovn 96c6deb link unknown /pj-rehearse periodic-ci-openshift-installer-master-altinfra-periodics-e2e-gcp-capi-ovn
ci/rehearse/openshift/installer/release-4.17/altinfra-e2e-gcp-ovn-byo-network-capi aea0b79 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-byo-network-capi
ci/rehearse/openshift/installer/release-4.17/altinfra-e2e-gcp-capi-ovn 1027c22 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-capi-ovn
ci/rehearse/openshift/installer/release-4.17/altinfra-e2e-gcp-ovn-secureboot-capi 1027c22 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-secureboot-capi
ci/rehearse/openshift/installer/release-4.17/altinfra-e2e-gcp-ovn-xpn-capi 1027c22 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-xpn-capi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants