-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3517: Add the GCP CAPI periodic test #51942
base: master
Are you sure you want to change the base?
Conversation
@barbacbd: This pull request references CORS-3517 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @patrickdillon |
/pj-rehearse |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
FEATURE_GATES: '["ClusterAPIInstall=true"]' | ||
FEATURE_SET: CustomNoUpgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion late last week with the TRT team, I understood that we want to favor testing the TechPreview feature set--not using individual gates like this. So for the goal of this PR, you should check whether GCP Tech Preview tests are present in the release periodics:
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/release/openshift-release-master__nightly-4.16.yaml
and
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/release/openshift-release-master__ci-4.16.yaml
It looks like GCP techpreview jobs are in the ci periodics, but not the nightly periodics. So I believe we want to add the gcp periodics to the nightly config. AWS is also missing from the nightly config, so if you can add that at the same time that would be appreciated.
/pj-rehearse |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The tech preview periodics should go into the openshift/release config. See https://github.com/openshift/release/pull/51731/files for examples Soon we can remove this entire altinfra variant |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-capi-ovn |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-installer-release-4.16-altinfra-e2e-gcp-ovn-secureboot-capi |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barbacbd, r4f4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-byo-network-capi |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@barbacbd: job(s): pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-byo-network-capi either don't exist or were not found to be affected, and cannot be rehearsed |
@barbacbd: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
/pj-rehearse pull-ci-openshift-installer-release-4.17-altinfra-e2e-gcp-ovn-xpn-capi |
@barbacbd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.