Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPEDGE-1093: fix: adding retries for dnf installs #51951

Merged
merged 1 commit into from
May 14, 2024
Merged

OCPEDGE-1093: fix: adding retries for dnf installs #51951

merged 1 commit into from
May 14, 2024

Conversation

jeff-roche
Copy link
Contributor

Fixes:

  • Periodic DNF failures
  • Git not being found sometimes

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot

@jeff-roche: This pull request references OCPEDGE-1093 which is a valid jira issue.

In response to this:

Fixes:

  • Periodic DNF failures
  • Git not being found sometimes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeff-roche
Copy link
Contributor Author

jeff-roche commented May 13, 2024 •
edited

/hold for review and testing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@jeff-roche
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-seedgen-aws-ocp-4-15

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@jeff-roche
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 13, 2024
@jeff-roche
Copy link
Contributor Author

/unhold tests successfully ran the metal config step

@jeff-roche
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-seedgen-aws-ocp-4-15

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2024
@jeff-roche
fix: adding retries for dnf installs
6a6fae4 
chore: updating the echo messaging on the retry  function
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jeff-roche: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-lifecycle-agent-main-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Registry content changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-parallel-conformance N/A periodic Registry content changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-seedgen-aws-ocp-4-15 N/A periodic Registry content changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-seedgen-aws-ocp-4-16 N/A periodic Registry content changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-image-based-upgrade-e2e-serial-conformance N/A periodic Registry content changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-image-based-upgrade-e2e-parallel-conformance N/A periodic Registry content changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-serial-conformance N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jeff-roche
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-seedgen-aws-ocp-4-15

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor

/lgtm

The retry is working, looking good, thanks @jeff-roche !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeff-roche
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2024
@jeff-roche
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@deepsm007
Copy link
Contributor

/hold
batch failure while merging, i'll unhold after clearing the batch

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@deepsm007
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7f320f6 into openshift:master May 14, 2024
13 checks passed
@jeff-roche jeff-roche deleted the ibu-metal-config-fix branch May 14, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggfoobar eggfoobar eggfoobar left review comments

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

Assignees

@eggfoobar eggfoobar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@jeff-roche @openshift-ci-robot @eggfoobar @deepsm007