-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-4504 Add integration helm test run #51953
Conversation
This PR needs to be merged first: openshift-service-mesh/istio#15 |
/hold |
To be able to run the rehearse over the new test we need merged first: openshift-service-mesh/istio#15 |
# SRC_PATH does end with /. : the content of the source directory is copied into dest directory | ||
oc cp ./. "${MAISTRA_NAMESPACE}"/"${MAISTRA_SC_POD}":/work/ | ||
oc cp ${KUBECONFIG} ${MAISTRA_NAMESPACE}/${MAISTRA_SC_POD}:/work/ci-kubeconfig | ||
oc cp `which oc` ${MAISTRA_NAMESPACE}/${MAISTRA_SC_POD}:/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to copy oc
. It's already present in the builder image.
I realize that this cp
command is present in all jobs. We can perform a cleanup in a follow up pr though, no rush.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll open a new one to delete this oc cp
/pj-rehearse ack |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This past execution is a false positive: The test fails |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
PR not ready to be merged, stills fails some of the test that are being executed |
cd /work && \ | ||
entrypoint \ | ||
prow/integ-suite-ocp.sh \ | ||
helm 'TestAmbientInstall|TestAmbientInstallMultiNamespace'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why skip those? Last time I checked, they were working fine on OCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing because they are failing in a previous run. Locally works everything but in our ci they are failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth to investigate the failure
Skipping ambiet tests on helm suite Skip on helm suite upgrade test
I ran the test locally skipping the upgrade tests and passing the suite. Adding the skip of the upgrade test and running the test again to check the result |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Testing more changes to avoid helm failure Unset GCP_REGISTRIES to avoid error running helm upgrade setup unset GCP_REGISTRIES for helm test
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse pull-ci-openshift-service-mesh-istio-master-istio-integration-helm |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/retest |
/pj-rehearse ack |
@fjglira: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asmigala, fjglira, jwendell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fjglira: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Jira: https://issues.redhat.com/browse/OSSM-4504
Adding test job to run istio upstream integration helm test to the pre submit jobs in our fork