Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCA 4.14/4.16/main branch update #51963

Merged
merged 2 commits into from
May 16, 2024
Merged

LCA 4.14/4.16/main branch update #51963

merged 2 commits into from
May 16, 2024

Conversation

jc-rh
Copy link
Contributor

@jc-rh jc-rh commented May 13, 2024

No description provided.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 13, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/retest

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/retest

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-release-4.14-ibu-e2e-flow

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-main-ibu-e2e-flow

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@donpenney
Copy link
Contributor

/lgtm

jeff-roche
jeff-roche reviewed May 14, 2024
View reviewed changes
...perator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-release-4.14.yaml Outdated
LCA_PULL_REF: pipeline:lifecycle-agent-operator
env:
OCP_BASE_VERSION: "4.14"
OCP_IMAGE_SOURCE: ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this release to test against the latest released image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e flow should also probably be added to the 4.15 branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologize if I asked about this before, what exactly is this version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCP_BASE_VERSION is the version of OCP that will be used for the seed and target clusters
OCP_IMAGE_SOURCE determines where those images are pulled from (ci is images built in CI, release will use officially publically released images of OCP). I'm of the opinion that for release branches, we should be testing against released OCP images

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this comment was merely stating that the config file for release-4.15 does not have this e2e workflow in it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse max

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/retest

@jc-rh
Copy link
Contributor Author

jc-rh commented May 14, 2024

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-parallel-conformance

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-release-4.16-integration

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-release-4.16-markdownlint

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-release-4.16-security

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-release-main-security

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jc-rh: job(s): pull-ci-openshift-kni-lifecycle-agent-release-main-security either don't exist or were not found to be affected, and cannot be rehearsed

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-main-integration

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-main-ibu-e2e-flow

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-main-security

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@jc-rh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-parallel-conformance 4bf4a29 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-parallel-conformance
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-image-based-upgrade-e2e-serial-conformance 4bf4a29 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-image-based-upgrade-e2e-serial-conformance
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-image-based-upgrade-e2e-parallel-conformance 4bf4a29 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.15-image-based-upgrade-e2e-parallel-conformance
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-serial-conformance 4bf4a29 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.16-image-based-upgrade-e2e-serial-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jc-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 15, 2024
@jc-rh
Copy link
Contributor Author

jc-rh commented May 15, 2024

@nishant-parekh This PR is ready. Periodic conformance tests are expected to fail.

@donpenney
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@jc-rh
Copy link
Contributor Author

jc-rh commented May 16, 2024

/assign @lack

@lack
Copy link
Contributor

lack commented May 16, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: donpenney, jc-rh, lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a597919 into openshift:master May 16, 2024
42 of 46 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@jc-rh: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_openshift-kni_quay using file core-services/image-mirroring/openshift-kni/mapping_openshift-kni_quay

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-parekh nishant-parekh nishant-parekh left review comments

@jeff-roche jeff-roche jeff-roche requested changes

@mresvanis mresvanis Awaiting requested review from mresvanis

Assignees

@lack lack

@donpenney donpenney

@jeff-roche jeff-roche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@jc-rh @openshift-ci-robot @donpenney @lack @jeff-roche @nishant-parekh