-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipi-gcp-manual-oidc to clean up credentials after cluster #51964
ipi-gcp-manual-oidc to clean up credentials after cluster #51964
Conversation
By cleaning up the credentials after the cluster, we avoid causing credentials related errors during the must-gather that is executed as part of the normal cluster deprovision chain.
1e6b1a1
to
71e2a73
Compare
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-gcp-manual-oidc pull-ci-openshift-cloud-credential-operator-release-4.16-e2e-gcp-manual-oidc pull-ci-openshift-cloud-credential-operator-release-4.15-e2e-gcp-manual-oidc |
@jstuever: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
looks like the rehearsal failure is unrelated, let's try again. |
@flavianmissi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/assign @mold |
@jstuever: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@jstuever: GitHub didn't allow me to assign the following users: mold. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @dlom |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlom, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jstuever: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
By cleaning up the credentials after the cluster, we avoid causing credentials related errors during the must-gather that is executed as part of the normal cluster deprovision chain.