Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipi-gcp-manual-oidc to clean up credentials after cluster #51964

Merged
merged 1 commit into from
May 14, 2024

Conversation

jstuever
Copy link
Contributor

By cleaning up the credentials after the cluster, we avoid causing credentials related errors during the must-gather that is executed as part of the normal cluster deprovision chain.

By cleaning up the credentials after the cluster, we avoid causing
credentials related errors during the must-gather that is executed as
part of the normal cluster deprovision chain.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jstuever: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-credential-operator-master-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.17-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.16-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.15-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.14-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.13-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.12-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.11-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.10-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-master-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.17-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.16-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.15-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.14-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.16-periodics-e2e-gcp-manual-oidc N/A periodic Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.15-periodics-e2e-gcp-manual-oidc N/A periodic Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.14-periodics-e2e-gcp-manual-oidc N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from neisw and xueqzhan May 13, 2024 19:30
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jstuever: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-credential-operator-master-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.17-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.16-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.15-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.14-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.13-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.12-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.11-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cloud-credential-operator-release-4.10-e2e-gcp-manual-oidc openshift/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-master-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.17-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.16-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.15-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.14-e2e-gcp-manual-oidc openshift/cluster-storage-operator presubmit Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.16-periodics-e2e-gcp-manual-oidc N/A periodic Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.15-periodics-e2e-gcp-manual-oidc N/A periodic Registry content changed
periodic-ci-openshift-cloud-credential-operator-release-4.14-periodics-e2e-gcp-manual-oidc N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@jstuever
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-gcp-manual-oidc pull-ci-openshift-cloud-credential-operator-release-4.16-e2e-gcp-manual-oidc pull-ci-openshift-cloud-credential-operator-release-4.15-e2e-gcp-manual-oidc

@openshift-ci-robot
Copy link
Contributor

@jstuever: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@flavianmissi
Copy link
Member

looks like the rehearsal failure is unrelated, let's try again.
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-gcp-manual-oidc pull-ci-openshift-cloud-credential-operator-release-4.16-e2e-gcp-manual-oidc pull-ci-openshift-cloud-credential-operator-release-4.15-e2e-gcp-manual-oidc

@openshift-ci-robot
Copy link
Contributor

@flavianmissi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jstuever
Copy link
Contributor Author

/assign @mold
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jstuever: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@jstuever: GitHub didn't allow me to assign the following users: mold.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mold
/pj-rehearse ack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstuever
Copy link
Contributor Author

/assign @dlom

@dlom
Copy link
Contributor

dlom commented May 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ea89762 into openshift:master May 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants