-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] OCPBUGS-32250: Prevent UniqueHost from stopping plugin chain #574
base: master
Are you sure you want to change the base?
Conversation
@gcs278: This pull request references Jira Issue OCPBUGS-32250, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix UniqueHost so that it doesn't completely stop the plugin chain if the route is not "activated" because the the ResourceVersion on the route didn't change. This is a problem for resyncs as the ResourceVersion doesn't change, but the plugin change should continue.
3bdd1fb
to
cb444e6
Compare
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fix UniqueHost so that it doesn't completely stop the plugin chain if the route is not "activated" because the the ResourceVersion on the route didn't change. This is a problem for resyncs as the ResourceVersion doesn't change, but the plugin change should continue.
WIP because I need to test more, and possibly develop E2Es to reproduce this scenario.