Print user@host when connecting with sftp #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to d989217110932490ba8ce92127a9a6838878928b, using sftp user@host would print "Connected to user@host", because the 'host' variable would also contain the username. Parsing switched in the above mentioned commit for good reasons, but some users prefer to see the username if it was specified on the command line and never noticed that it did not show up when they specified a path on connection. Restore the behavior of showing the username if one was specified and make it consistent regardless of whether a path was passed on the command line or not.
|
The two CI failures seem to be due to network issues and unrelated to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to d989217110932490ba8ce92127a9a6838878928b, using sftp user@host would print "Connected to user@host", because the 'host' variable would also contain the username.
Parsing switched in the above mentioned commit for good reasons, but some users prefer to see the username if it was specified on the command line and never noticed that it did not show up when they specified a path on connection.
Restore the behavior of showing the username if one was specified and make it consistent regardless of whether a path was passed on the command line or not.