Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setup-envtest to last working commit #205

Merged

Conversation

jpodivin
Copy link
Contributor

Change[0] in controller-runtime is causing our tests to fail with go version mismatch.

This version restriction should be removed once the issue is fixed in the controller-runtime

[0] kubernetes-sigs/controller-runtime#2693

Change[0] in controller-runtime is causing our tests to fail with go version mismatch.

This version restriction should be removed once the issue is fixed in the controller-runtime

[0] kubernetes-sigs/controller-runtime#2693

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, jpodivin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3a7330c into openstack-k8s-operators:main Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants