Issue 1498

[PiotrKozlowski]

for: https://github.com/openstax/unified/issues/1498

Testing:

Go to /books/physics/pages/1-introduction301 - you should be redirected to /books/physics/pages/1-introduction

Only this URL is set up

[TomWoodward]

this is fine the way it is, you can ignore my comment about the browserspec

[PiotrKozlowski]

ok then

[jarosik10]

Looks good.

[PiotrKozlowski]

Craco is not working in this case... dilanx/craco#143 (comment)
I'll try creating a fork of react-scripts as advised in the documentation and modify it to check for CI variable and disable hot reloading if it is set

[TomWoodward]

@PiotrKozlowski this is getting out of control, if necessary we could disable test:browser which i think is the only one using the dev server.

it looks like you must have done something to fix test:unit, because that is passing now, that should be good enough

[TomWoodward]

I see you added server mode to test:unit and that seems to have helped, but that confuses me because the unit tests shouldn't be using the puppeteer environment. If the unit tests are running the puppeteer environment that is a problem

[PiotrKozlowski]

Idk why this is happening, but I think I've just found a solution. I'll push a commit in a sec

[PiotrKozlowski]

Oh no :( I really thought this was gonna work: 7d8fa6f#diff-9531c01f38fb3a33c0a25db522822e353b143e69b9d43246d8e32bcb66662bfdR1

One more thing I can think of is this comment: webpack/webpack-dev-server#1744 (comment)

I didn't experience this locally but maybe this is what is happening in CI? I think we are running unit, browser and build tests simultaneously?

[TomWoodward]

maybe try turning the actual hot param off in your config override? https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/config/webpackDevServer.config.js#L73

[PiotrKozlowski]

@TomWoodward This is not working: dilanx/craco#143 (comment)

I've tested this locally on all different ways and even by modifying node_modules package - I didn't found a way to disable hot reloading for webpack-dev-server