Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional values to Vending field #1145

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CornerSyrup
Copy link

@CornerSyrup CornerSyrup commented Feb 28, 2024

Adding keys from wiki and taginfo to dictionary. Only coping those familiar and commonly used.

Changes:

  • Add missing but common keys
  • Sort to organise

Copy link

github-actions bot commented Mar 1, 2024

🍱 You can preview the tagging presets of this pull request here.

@tyrasd
Copy link
Member

tyrasd commented Mar 1, 2024

like in #1146: would you mind explaining the reasoning behind which options you selected for this PR? For example, "alcohol" does not seem to be documented in the wiki, is not really "in use" according to taginfo…

@tyrasd tyrasd added the waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-value waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants