Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop "Portable Toilets" preset #1159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drop "Portable Toilets" preset #1159

wants to merge 1 commit into from

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Mar 13, 2024

Fixes #1148 and in addition changes the following strings:

  • rename generic amenity=toilets preset to "Toilets" (was: "Restroom"), as restroom is typically only used for rooms in a building, but the tag can also be used for outdoor toilets
  • rename field for "toilets" tag to "Restroom" (for the opposite reason as above)
  • move alias "Water Closet" to "Flush Toilets" preset

* rename generic amenity=toilets preset to "Toilets" (was: "Restroom"), as restroom is typically only used for indoor toilets, but the tag can also be used for outdoor ones
* rename field for "toilets" tag to "Restroom" (for the opposite reason as above)
* move alias "Water Closet" to "Flush Toilets" preset

fixes #1148
@tyrasd tyrasd added the new-label changes the name, aliases or terms of a preset label Mar 13, 2024
@tyrasd tyrasd added this to the v6.8 milestone Mar 13, 2024
Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I have the open question (last paragraph) if we should remove the portable field…

In #1148 (comment) the language and changes where approved.


rename generic amenity=toilets preset to "Toilets" (was: "Restroom"), as restroom is typically only used for rooms in a building, but the tag can also be used for outdoor toilets

When a toilet is mapped separately inside the building shape, it also get this updated name, now. Which is something we have to live with, since we cannot target the surrounding shape. I think this is fine. Example https://pr-1159--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n5938578259&locale=en&map=20.00/47.84838/12.07912


Example "flush" https://pr-1159--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n10284044581&locale=en&map=20.00/47.84891/12.09018


Example "portable" https://pr-1159--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=n9124438348&locale=en&map=20.00/48.11587/12.34760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Portable Toilets" preset doesn't match the wiki
2 participants