Community centre

[tiptoptom]

CC: #1015 #605

[github-actions]

🍱 You can preview the tagging presets of this pull request here.

[tordans]

@tiptoptom in general this looks good. Could you please add some context to your PR to make it easer to review and also add some example links to those places using the preview that was linked in the PR by the github action. Please add usage stats on the given presets as well.

For example, why did you add separate presets per center-type? They all use the same fields and icon of their parent, so we might as well just use the parent + the new field?

One specific think I wonder is: You reference #1015 which talks about https://wiki.openstreetmap.org/wiki/Key:community_centre:for but your PR does not use this tag. Is this because you consider this something to be added later or are there other reasons?

Thanks for this PR!

---

Update: Two more things we need to check

• What does the search look like with those presets, are there duplicated results?
• Are there good Wikidata items already, so we get a nice info-(i) text? (Please add screenshots) (See https://github.com/openstreetmap/id-tagging-schema/pull/1239/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35R13)

[tiptoptom]

For example, why did you add separate presets per center-type? They all use the same fields and icon of their parent, so we might as well just use the parent + the new field?

I have made various presets, as some of the names have little to do with "community center". For example, a club home of a sports club would not be called a community center but a club home.

[tiptoptom]

One specific think I wonder is: You reference #1015 which talks about https://wiki.openstreetmap.org/wiki/Key:community_centre:for but your PR does not use this tag. Is this because you consider this something to be added later or are there other reasons?

I just wanted to put them in copy, as it is something similar.

[tiptoptom]

add some example links to those places using the preview that was linked in the PR by the github action

community_centre = village_hall
https://pr-1200--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w428990719&locale=en&map=20.00/46.58519/14.41819

community_centre = club_home
https://pr-1200--ideditor-presets-preview.netlify.app/id/dist/#background=nrw_vdop_wms&disable_features=boundaries&id=n6840341676&map=20.00/50.95895/5.37044

community_centre = cultural_centre
https://pr-1200--ideditor-presets-preview.netlify.app/id/dist/#background=nrw_vdop_wms&disable_features=boundaries&id=n8879633245&map=20.00/52.05062/8.59420

[tiptoptom]

Please add usage stats on the given presets as well.

https://taghistory.raifer.tech/#***/amenity/community_centre&***/community_centre/club_home&***/community_centre/cultural_centre&***/community_centre/community_hall&***/community_centre/family_centre&***/community_centre/parish_hall&***/community_centre/village_hall

---

What does the search look like with those presets, are there duplicated results?

[tordans]

@tiptoptom do you know more about the values that the "most used values" feature of the dropdown shows?
Eg. is club_house the same as the club_home.
It is always a bit confusing for users if those values are visible in the list but not explained/translated but others are.

[tordans]

@tiptoptom One thing we should do before merging is improving the info-i text:

Eg links to https://wiki.openstreetmap.org/wiki/Item:Q6740
But it should link to the specific sub tag.

You might need to add new wikidata items for those. Or add an explicit reference https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference to the sub presets.

[tordans]

@tiptoptom what are your thoughts on adding the sub-group-dropdown to the sub-presets as well?
I always find it a bit weird when I come from a preset, select a sub-preset via dropdown and then the dropdown disappears. It is hard to understand how to go back than. – This is not an issue if the primary usage will be selecting the sub-preset via search. However your graph showed a lot of usage without sub tags, so the first case is one that will happen a lot, right?

Right now it looks like this. The additional dropdown could be the first item on this fieldset