Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset man_made=paifang #1214

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

SteveLz
Copy link
Contributor

@SteveLz SteveLz commented May 6, 2024

Wiki page: man_made=paifang

@SteveLz
Copy link
Contributor Author

SteveLz commented May 6, 2024

The svg below can be used as an icon if appropriate:
Paifang

@tordans
Copy link
Collaborator

tordans commented Jun 5, 2024

Hey @SteveLz the test in your PR failed because you added new fields to the new presets that do not exist, yet. You need to add those ad separate file. However, please check if they are crucial and used a lot, they look like very detailed micromapping to me that we might want to not include in the first version of this preset.

The draft docs at https://github.com/openstreetmap/id-tagging-schema/pull/1229/files#diff-22e674f3d1da91695fbafd4d2c81f91246cfabab3d16dcf6492e6024797b4da5R1 give some guidance on which fields/tags to add.

Please also check the draft at #1239 and add some testing links and screenshots once the preview of this PR was created. Thanks!

Copy link

github-actions bot commented Jun 6, 2024

🍱 You can preview the tagging presets of this pull request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants