Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding Munin script URLs with an environment variable #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented Mar 24, 2024

In order to at least partially support monitoring deployments not listening on localhost and/or using HTTPS.

E.g.:

[mod_tile_fresh]
env.MOD_TILE_URL = {url of /mod_tile endpoint}

[mod_tile_latency]
env.MOD_TILE_URL = {url of /mod_tile endpoint}

[mod_tile_response]
env.MOD_TILE_URL = {url of /mod_tile endpoint}

[mod_tile_zoom]
env.MOD_TILE_URL = {url of /mod_tile endpoint}

See here for documentation.

Resolves #418

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.40%. Comparing base (743cf65) to head (40bf4e7).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   79.98%   80.40%   +0.41%     
==========================================
  Files          24       24              
  Lines        5926     5925       -1     
==========================================
+ Hits         4740     4764      +24     
+ Misses       1186     1161      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Munin mod_tile_* hardcoded URL
2 participants